Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo encrytion 2 #13445

Closed
wants to merge 3 commits into from
Closed

Conversation

Montel
Copy link
Contributor

@Montel Montel commented Feb 12, 2019

There was a typo in method RESTAPI name. (Missing "r")

@MarcosSpessatto
Copy link
Member

Closing in favor of #13334. @Montel I'm closing this, in favor of the first PR you did, apparently in this PR you did not use the develop as a base branch again, but there is no problem, I fixed the first PR and now it is okay. Thank you for help us. 👍

@Montel
Copy link
Contributor Author

Montel commented Feb 12, 2019

Hi,
ok.
As I don't know very well github, for my future patch what is the correct method for create my branch from correct branch ? What command I need to use in console ?

Thanks
Regards

@MarcosSpessatto
Copy link
Member

@Montel no worries, you must create a new branch from develop, first you must be in the develop branch(git checkout develop), then you will create your new branch(git checkout nameofnewbranch), then finally you will be able to commit, push, and open a new PR. :) If you have any doubt, feel free to contact in Rocket.Chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants