Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Simple call dialing sound & notification #13595

Conversation

alonelion1987
Copy link
Contributor

@alonelion1987 alonelion1987 commented Mar 1, 2019

Hello!

closes #3416 and #3830

simple implementation: the sound is still one and is stored in the folder public/sounds/sound-call.mp3.

while the creator jitsi conference remains in the room and did not close it himself, for all those who are invited to the room a continuous melody is distributed.

If you want to change the sound, just replace this file with the same name. But in the future it is better to create a system in order to be able to download, delete or select sounds for each user.

Now when you call and invite to a jitsi room, other users are given the opportunity to immediately go to the jitsi room or reject the call (via modal window invite).

@wreiske
Copy link
Contributor

wreiske commented Mar 2, 2019

Awesome! I'm curious if you could use the existing sounds in Rocket/custom sounds feature and just include a new default sound for a ringer?

image

I also made some custom ring sounds for rocket awhile back: https://github.com/RocketChat/Rocket.Chat/issues/3416#issuecomment-429342513

Check out https://github.com/RocketChat/Rocket.Chat/blob/c736766e8036169bc27521d1c259b0e8863602b5/packages/rocketchat-custom-sounds/client/lib/CustomSounds.js

@alonelion1987
Copy link
Contributor Author

ok thank you i will check

@alonelion1987 alonelion1987 changed the title Simple call dialing sound & notification [NEW] Simple call dialing sound & notification Mar 15, 2019
@engelgabriel engelgabriel added this to the 1.0.0 milestone Mar 22, 2019
@engelgabriel engelgabriel modified the milestones: 1.0.0, 1.1.0 Apr 6, 2019
@rodrigok rodrigok added this to PRs in 1.1.0 Review May 10, 2019
@rodrigok rodrigok moved this from PRs to PRs Next in 1.1.0 Review May 15, 2019
@rodrigok rodrigok modified the milestones: 1.1.0, 1.2.0 May 15, 2019
@rodrigok rodrigok removed this from PRs Next in 1.1.0 Review May 15, 2019
@engelgabriel engelgabriel modified the milestones: 1.2.0, 1.3.0 Jul 10, 2019
@sampaiodiego sampaiodiego modified the milestones: 1.3.0, 1.4.0 Jul 25, 2019
@wreiske
Copy link
Contributor

wreiske commented Aug 21, 2019

👀

@sampaiodiego sampaiodiego modified the milestones: 2.0.0, 2.1.0 Sep 6, 2019
@engelgabriel engelgabriel modified the milestones: 2.1.0, 2.2.0 Oct 13, 2019
@rodrigok rodrigok modified the milestones: 2.2.0, 2.3.0 Oct 19, 2019
@rodrigok
Copy link
Member

@alonelion1987 can you fix these conflicts?

@engelgabriel engelgabriel modified the milestones: 2.3.0, 3.1.0 Mar 17, 2020
@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
@engelgabriel engelgabriel modified the milestones: 3.2.0, 4.1.0 May 7, 2020
@engelgabriel
Copy link
Member

We refactoring the whole UI using ReactJS and will completely change the video conference experience. The idea is to add an abstraction layer so we can connect multiple video backends. So although this PR is unlikely to be merged as is, it will be a starting point for our new implementation. Thanks, @alonelion1987 for the contribution!

@holzfelix
Copy link

would be amazing if this can be merged ...

@alexandrtovmach
Copy link

Based on #13595 (comment) this PR should be closed.

@JacsonPaz
Copy link

Hi team! Any updates about this issue? We can't abandon Skype because we don't have a "incoming call notification" on channels/teams/threads... All team are at home now, and its very important method to get all in-time meetings .

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet