New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Simple call dialing sound & notification #13595
[NEW] Simple call dialing sound & notification #13595
Conversation
Awesome! I'm curious if you could use the existing sounds in Rocket/custom sounds feature and just include a new default sound for a ringer? I also made some custom ring sounds for rocket awhile back: https://github.com/RocketChat/Rocket.Chat/issues/3416#issuecomment-429342513 |
ok thank you i will check |
👀 |
@alonelion1987 can you fix these conflicts? |
We refactoring the whole UI using ReactJS and will completely change the video conference experience. The idea is to add an abstraction layer so we can connect multiple video backends. So although this PR is unlikely to be merged as is, it will be a starting point for our new implementation. Thanks, @alonelion1987 for the contribution! |
would be amazing if this can be merged ... |
Based on #13595 (comment) this PR should be closed. |
Hi team! Any updates about this issue? We can't abandon Skype because we don't have a "incoming call notification" on channels/teams/threads... All team are at home now, and its very important method to get all in-time meetings . Thanks in advance! |
Hello!
closes #3416 and #3830
simple implementation: the sound is still one and is stored in the folder
public/sounds/sound-call.mp3
.while the creator jitsi conference remains in the room and did not close it himself, for all those who are invited to the room a continuous melody is distributed.
If you want to change the sound, just replace this file with the same name. But in the future it is better to create a system in order to be able to download, delete or select sounds for each user.
Now when you call and invite to a jitsi room, other users are given the opportunity to immediately go to the jitsi room or reject the call (via modal window invite).