-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Translation interpolations for many languages #13751
Conversation
@sampaiodiego do we need to upload the files directly to LingoHub once this is merged? Or are we still doing the auto-fetch from here? |
@engelgabriel it is currently turned off for languages other than english.. I'll turned it on again as we're already missing some translations there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no need to do any changes on cleanHistory.js
file.. the usage of the t
function is correct and working there.
all other changes on translation files are welcome.
97c43d7
to
db6f83d
Compare
@sampaiodiego Please review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are many others where Prune_Warning_all
became %srning_all
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Co-Authored-By: fliptrail <40834245+fliptrail@users.noreply.github.com>
Looks like there was a problem with my RegEx. Will see to it tomorrow. |
Closes #12130, Closes #12001
Fixes these and some string modifier issues.
Initial State
Final State