Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Remove all closed Livechat chats #13991

Merged
merged 11 commits into from
Oct 18, 2019
Merged

[NEW] Remove all closed Livechat chats #13991

merged 11 commits into from
Oct 18, 2019

Conversation

knrt10
Copy link
Contributor

@knrt10 knrt10 commented Apr 3, 2019

Closes #12279

@renatobecker would you please review. Closing chats and also showing delete all button according to filter set in room.

@geekgonecrazy geekgonecrazy changed the title [FEATURE] Remove all Livechat chats [NEW] Remove all Livechat chats Apr 11, 2019
@knrt10 knrt10 force-pushed the issue12279 branch 5 times, most recently from 46955aa to 772c31e Compare April 28, 2019 08:32
@renatobecker-zz renatobecker-zz added this to the 2.1.0 milestone Aug 26, 2019
@renatobecker-zz renatobecker-zz modified the milestones: 2.1.0, 2.2.0 Sep 25, 2019
@renatobecker-zz
Copy link

Hi @knrt10!
Can you please fix the conflicts here?

Thanks.

@knrt10
Fixed and rebased code
9a5cdd1 
Signed-off-by: knrt10 <tripathi.kautilya@gmail.com>
@knrt10
Copy link
Contributor Author

knrt10 commented Oct 4, 2019

@renatobecker fixed. Please review

@renatobecker-zz renatobecker-zz changed the title [NEW] Remove all Livechat chats [NEW] Remove all closed Livechat chats Oct 9, 2019
@renatobecker-zz
Copy link

renatobecker-zz commented Oct 11, 2019 •
edited
Loading

Hi @knrt10 I'have made several improvements in this PR.
As you can see below, I replaced that big red button with a popover, I think it's a better UX/UI approach:

Screen Shot 2019-10-11 at 18 40 58

Another important thing, now the process of removing rooms is implemented on server side, so we just need to call the server method once.
Your opinion about these changes would be very appreciated, thanks for your help with this implementation.
Since I worked in this PR I'm requesting the review from @sampaiodiego and/or @rodrigok, Ok?

@renatobecker-zz renatobecker-zz requested review from sampaiodiego and rodrigok and removed request for renatobecker-zz October 11, 2019 21:46
@knrt10
Copy link
Contributor Author

knrt10 commented Oct 13, 2019

LGTM!

@rodrigok rodrigok merged commit 16a179a into RocketChat:develop Oct 18, 2019
@rodrigok rodrigok mentioned this pull request Oct 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodrigok rodrigok rodrigok approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees

@renatobecker renatobecker

Labels
squad: omnichannel subj: livechat
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

[Livechat] Remove all chats
5 participants
@knrt10 @renatobecker-zz @rodrigok @tassoevan @renatobecker