Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Threads V 1.0 #13996

Merged
merged 112 commits into from
Apr 7, 2019
Merged

[NEW] Threads V 1.0 #13996

merged 112 commits into from
Apr 7, 2019

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Apr 3, 2019

Based on #13394

Closes #6888
Closes #13843
Closes #1112

Coauthored with @khaledalyawad and @mrsimpson

compressed reply message

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13996 April 6, 2019 20:51 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13996 April 6, 2019 21:08 Inactive
@engelgabriel
Copy link
Member

@mrsimpson

You are too fast!! heheheh

Yes, we will give it a try to "compress" the tread display in the parent channel, turning it into a single line, with the small avatar version, like when you use RC in compress mode.

We were already working on the message box for the thread area, it is now live.

I am also uneasy with the work THREAD being the main word, I think we should use the wording in a way that REPLY is the main word, and even the ICON should be the REPLY icon all the time, and remove this THREAD icon altogether.

Please join us at https://threads-qa.rocket.chat to test the latest version of threads

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13996 April 7, 2019 01:49 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13996 April 7, 2019 02:39 Inactive
@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-13996 April 7, 2019 02:52 Inactive
@khaledalyawad
Copy link

this is awesome!, testing now!

@engelgabriel
Copy link
Member

compressed reply message

@rodrigok
Copy link
Member

rodrigok commented Apr 7, 2019

@ggazzo we need to test this with one App installed and see if the app engine will not remove the new properties

@rodrigok rodrigok merged commit 14b79fe into develop Apr 7, 2019
@rodrigok rodrigok deleted the new-threads branch April 7, 2019 20:11
@rodrigok rodrigok mentioned this pull request Apr 28, 2019
@ghost
Copy link

ghost commented May 19, 2019

Hi, where is the toggle to turn of threaded replies? It's a nice feature but tastes differ, so is it possible to turn it off?

@mrsimpson
Copy link
Collaborator

Hi, where is the toggle to turn of threaded replies? It's a nice feature but tastes differ, so is it possible to turn it off?

@Korben3 as far as I recall it’s in the admin settings, section „threads“

Sent with GitHawk

@ghost
Copy link

ghost commented May 19, 2019

Thanks, seems like the docs on rocket.chat/docs hasn't been updated yet.

@ghost
Copy link

ghost commented May 19, 2019

@mrsimpson do you have an image of where to find this? It's for someone else that has rocket chat installed.

@yaxu
Copy link

yaxu commented May 30, 2019

Is there somewhere to discuss the threading UI? We've tried it for a while and the consensus is that it makes channels more difficult to read. For example:

image

The font is too small and the interleaving of threads makes it difficult to follow any of the discussion.

@khaledalyawad
Copy link

I think if we avoid/minimize posting notifications on the main thread this will make it cleaner. We can have a dedicated view to let users notified on what is new on the threads/discussions they are following

@zdumitru
Copy link
Contributor

Not forcing thread replies being sent to the main channel will make things look cleaner. There is a feature request for that. You can upvote it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Threads vs Discussions Topics and requests: a hierarchy of rooms with ending sub-rooms Threads
9 participants