[IMPROVE] Replace livechat:externalMessages publication by REST #15643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker-zz
suggested changes
Nov 11, 2019
| this.roomId = Template.currentData().rid; | ||
| this.subscribe('livechat:externalMessages', Template.currentData().rid); | ||
| if (this.roomId) { | ||
| const { messages } = await APIClient.v1.get(`livechat/messages.external?roomId=${ this.roomId }`); |
There was a problem hiding this comment.
We need to use pagination here, otherwise, only the first fetch will be displayed.
renatobecker-zz
suggested changes
Nov 13, 2019
|
|
||
| export class LivechatExternalMessage extends Base { | ||
| constructor() { | ||
| super('livechat_external_message'); |
There was a problem hiding this comment.
What about creating an index for the rid field?
It would provide more performance when finding records.
renatobecker-zz
approved these changes
Nov 13, 2019
tassoevan
pushed a commit
that referenced
this pull request
Nov 13, 2019
* Regression messageAttachments * [IMPROVE] Replace livechat:externalMessages publication by REST (#15643) * Replace livechat:externalMessages publication by REST * Fix lint * Add pagination to livechat external messages * Add index and remove obsolete collection * remove pages to dynamic
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.