-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Add a new stream to emit and listen room data events #15770
Conversation
Isn't better to keep it opened and just update the view? I think there are many other useful data there so I think users will immediately open the tab bar again. |
Sure. Do we already have a way to notify the client when specific records are updated(or removed)? If so, please let me know. Then we can use it to update the template data and keep the same behavior we had before. |
This pull request introduces 1 alert when merging aff0705 into 0f07ea5 - view on LGTM.com new alerts:
|
@sampaiodiego, I just pushed the changes following your suggestion. |
Since we replaced some
Meteor pub/sub
by theREST
approach, we lost the reactivity in a few templates, such as thevisitorInfo
.To keep the templates reactive, we have now a new
stream
to emit the changes related to the room data.In this first moment, only
Livechat Rooms
are allowed to listen to these events.