Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Add a new stream to emit and listen room data events #15770

Merged
merged 9 commits into from
Nov 20, 2019

Conversation

renatobecker-zz
Copy link

@renatobecker-zz renatobecker-zz commented Nov 12, 2019

Since we replaced some Meteor pub/sub by the REST approach, we lost the reactivity in a few templates, such as the visitorInfo.
To keep the templates reactive, we have now a new stream to emit the changes related to the room data.

In this first moment, only Livechat Rooms are allowed to listen to these events.

@sampaiodiego
Copy link
Member

Isn't better to keep it opened and just update the view? I think there are many other useful data there so I think users will immediately open the tab bar again.

@renatobecker-zz
Copy link
Author

renatobecker-zz commented Nov 13, 2019

Isn't better to keep it opened and just update the view? I think there are many other useful data there so I think users will immediately open the tab bar again.

Sure. Do we already have a way to notify the client when specific records are updated(or removed)? If so, please let me know. Then we can use it to update the template data and keep the same behavior we had before.
There are more cases like that, so it would be very helpful.

@lgtm-com
Copy link

lgtm-com bot commented Nov 14, 2019

This pull request introduces 1 alert when merging aff0705 into 0f07ea5 - view on LGTM.com

new alerts:

  • 1 for Comparison between inconvertible types

@renatobecker-zz renatobecker-zz changed the title [IMPROVE] Auto-close tabbar after closing livechat rooms [NEW] Add new streamer to emit and listen Livechat room events Nov 19, 2019
@renatobecker-zz renatobecker-zz changed the title [NEW] Add new streamer to emit and listen Livechat room events [NEW] Add a new stream to emit and listen Livechat room events Nov 19, 2019
@renatobecker-zz renatobecker-zz removed the request for review from ggazzo November 19, 2019 19:02
@renatobecker-zz renatobecker-zz changed the title [NEW] Add a new stream to emit and listen Livechat room events [NEW] Add a new stream to emit and listen room data events Nov 19, 2019
app/utils/lib/RoomTypeConfig.js Outdated Show resolved Hide resolved
Omnichannel Roadmap automation moved this from In progress to Needs review Nov 20, 2019
@renatobecker-zz
Copy link
Author

@sampaiodiego, I just pushed the changes following your suggestion.
Thanks.

Omnichannel Roadmap automation moved this from Needs review to Reviewer approved Nov 20, 2019
@sampaiodiego sampaiodiego merged commit 00f072a into develop Nov 20, 2019
Omnichannel Roadmap automation moved this from Reviewer approved to Done Nov 20, 2019
@sampaiodiego sampaiodiego deleted the auto-close-tabbar-livechat-rooms branch November 20, 2019 21:29
@sampaiodiego sampaiodiego mentioned this pull request Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants