Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Omnichannel Inquiry queues when removing chats #16603

Merged
merged 3 commits into from
Feb 18, 2020

Conversation

renatobecker
Copy link
Contributor

@renatobecker renatobecker commented Feb 14, 2020

We detected some issues related to the Omnichannel Inquiries when removing chats:

  • The streaming was relying on the rid field, but when removing an inquiry, only the _id is propagated, so it wasn't working properly.
  • Also, the inquiry was not being removed in some events when the room was removed, so the inquiry was becoming available even without the existence of the related room.

Some customers have experienced issues related to this case, as shown below:

db

@claassistantio
Copy link

claassistantio commented Feb 14, 2020

CLA assistant check
All committers have signed the CLA.

@renatobecker renatobecker changed the title [FIX] Omnichannel Inquiries queue when removing chats [FIX] Omnichannel Inquiry queues when removing chats Feb 14, 2020
@renatobecker renatobecker merged commit 566ff2d into develop Feb 18, 2020
@renatobecker renatobecker deleted the omnichannel/remove-inquiry-when-removing-room branch February 18, 2020 12:41
@sampaiodiego sampaiodiego modified the milestones: 4.0.0, 3.0.2 Feb 20, 2020
sampaiodiego pushed a commit that referenced this pull request Feb 20, 2020
* Fix Inquiry stream when removing omnichannel rooms.

* Remove unnecessary blank line.

* Remove unnecessary import files.
@sampaiodiego sampaiodiego mentioned this pull request Feb 20, 2020
sampaiodiego pushed a commit that referenced this pull request Feb 21, 2020
* Fix Inquiry stream when removing omnichannel rooms.

* Remove unnecessary blank line.

* Remove unnecessary import files.
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants