Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Livechat manager #1683

Merged
merged 9 commits into from
Dec 18, 2015
Merged

[WIP] Livechat manager #1683

merged 9 commits into from
Dec 18, 2015

Conversation

sampaiodiego
Copy link
Member

I'm finishing the livechat manager page.
This pages will be used livechat managers to configure livechat behaviors.

This is what I have for now:

User management

image

Department management

image

image

Triggers (only one atm)

image

Installation code

image

Appearance settings

image

@diogobernini
Copy link

Looking neat.

@engelgabriel engelgabriel deployed to rocket-chat-pr-1683 December 18, 2015 19:32 Active
@engelgabriel engelgabriel deployed to rocket-chat-pr-1683 December 18, 2015 20:11 Active
engelgabriel added a commit that referenced this pull request Dec 18, 2015
@engelgabriel engelgabriel merged commit 592291a into develop Dec 18, 2015
@engelgabriel engelgabriel deleted the livechat-manager-improvements branch December 18, 2015 20:29
@skyred
Copy link

skyred commented Dec 20, 2015

I guess this is not included in 0.9 release. I am wondering what steps that I need to do in order to test this?

@sampaiodiego
Copy link
Member Author

hey @skyred you can test it enabling the rocketchat:livechat meteor package in your dev environment.
if you want to test it in production, you'll have to build rocket.chat yourself.. we'll add it to our builds in the next weeks..

@skyred
Copy link

skyred commented Dec 28, 2015

I see v0.11.0 is tagged. On the other hand, the docker image is still at v0.9. Using Docker for creating sandboxes for testing is great, but it seems that this project has skipped a few releases on docker?

@Sing-Li
Copy link
Member

Sing-Li commented Dec 28, 2015

@skyred -- please make sure you are using this Docker image ... rocketchat/rocket.chat

https://hub.docker.com/r/rocketchat/rocket.chat/builds/

... if you want to explore the latest code instead of tested stable - as you can see, it is updated instantly (2 hours ago)

@skyred
Copy link

skyred commented Dec 28, 2015

Interestingly, this gets more confusing. Why does your organization keep two Docker repos?

https://hub.docker.com/_/rocket.chat/
https://hub.docker.com/r/rocketchat/rocket.chat/ (including Dockerfile in the project itself doesn't seem to be a common practice)

@Sing-Li
Copy link
Member

Sing-Li commented Dec 28, 2015

It is very common practice for rapidly-moving FOSS projects. Please just browse around at the repositories available at hub.docker.com to see many examples.

Our organization maintains only ONE repository:

https://hub.docker.com/u/rocketchat/dashboard/

We maintain THREE images, for the diverse needs of our global users community:

  1. Official - stable, reviewed by Docker committee rocket.chat - in a repository maintained by Docker
  2. Latest - stable, tested, latest available off our master branch rocketchat/rocket.chat:latest
  3. Develop - absolute latest, for those who need to work with the latest code rocketchat/rocket.chat:develop

See this (and other info available at our wiki) branching strategy details:

https://github.com/RocketChat/Rocket.Chat/wiki/Branches-and-Releases

This is Off Topic. Please post a new ticket if you would like to continue this discussion.

@skyred
Copy link

skyred commented Dec 28, 2015

I see your point now. Thanks for the information. I will report it back once I have the chance to test the feature related to this issue.

@sampaiodiego
Copy link
Member Author

so, docker images doesn't have livechat package installed.
I was discussing about this with @engelgabriel .. maybe we should release new images with livechat installed.

@Sing-Li
Copy link
Member

Sing-Li commented Dec 28, 2015

😞 True. Perhaps we need the LiveChat edition #1741 even sooner 😁

@skyred
Copy link

skyred commented Jan 4, 2016

rocketchat/rocket.chat:latest still uses the built package https://github.com/RocketChat/Rocket.Chat/blob/develop/Dockerfile#L19

I can't find the documentation on this project wiki about building from source. If someone can point me to the documentation, I might be able to build my own docker image for testing.

@sampaiodiego
Copy link
Member Author

@skyred you can follow this steps to build Rocket.Chat from source: here

but, in #1799 I'm adding livechat as default to develop branch. we'll merge it today and test it during the week to release it on master branch in the next week.

@skyred
Copy link

skyred commented Jan 9, 2016

I tested the latest develop built. It works well. Three quick comments:

  1. showing visitor's name is better than show their username, like guest-1, guest-2,..
  2. Images posted on the main window cannot be seen in the live chat.
  3. I guess there is no Android Notification yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants