[FIX] Apps page loading indefinitely if no Markeplace data

[gabriellsh]

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves a current function)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Hotfix (a major bugfix that has to be merged asap)
• Documentation Update (if none of the other choices apply)

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works (if applicable)
• I have added necessary documentation (if applicable)
• Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

[d-gubert]

I don't think this solves the underlying problem.

If the request to the Marketplace errors out, it will throw and the code will go to the catch clause, leaving the table in loading state.

But even if it didn't, the provider still waits for the Marketplace request to finish before it shows the installed apps. This makes the wait time longer to see data that is not that useful in the Apps page, for instance.

The best solution would be to decouple both requests, and prioritize the local apps list instead of the Marketplace one. In this way, the screen would quickly show results in the list while the Marketplace request (which takes longer to complete) finishes and complements the data being shown later.

This is even more beneficial to the Apps page, in which the Marketplace data for the apps is less relevant than the actual list of installed apps.

[d-gubert]

As a further note, this hurts us @RocketChat/apps during our development of Apps-Engine features, because we usually install the local version of the Apps-Engine, causing an error in the Marketplace request. Thus, our installed apps list does not appear 😞

[shiqimei]

I made a PR before #16258 for the non-react version. The thought is to lazy-load category labels and renders apps list first. Besides rendering local apps first, lazy-loading category labels is needed for apps installed from the marketplace here too.