Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Uncaught (in promise) undefined #18393

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[FIX] Uncaught (in promise) undefined #18393

merged 1 commit into from
Jul 28, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 27, 2020 •
edited
Loading

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@ggazzo ggazzo added this to the 3.6.0 milestone Jul 27, 2020
@ggazzo ggazzo requested a review from renatobecker July 27, 2020 23:15
@ggazzo ggazzo merged commit 8eb6fef into develop Jul 28, 2020
gabriellsh added a commit that referenced this pull request Jul 28, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
03076ed 
…/channel-avatar

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Uncaught (in promise) undefined (#18393)
@sampaiodiego sampaiodiego deleted the fix/stream-canned-responses branch July 28, 2020 16:23
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @gabriellsh @renatobecker