Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Omnichannel Current Chat issues #18718

Merged
merged 10 commits into from
Aug 29, 2020
Merged

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Aug 28, 2020

Proposed changes

Fixes:

  • no translations in some strings
  • default order change
  • add custom field filter
  • add remove button to closed chats
  • deletion confirmation for remove buttons

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@MartinSchoeler MartinSchoeler requested a review from a team August 28, 2020 20:08
@ggazzo ggazzo changed the title [REGRESSION] Omnichannel Current Chat issues Regression: Omnichannel Current Chat issues Aug 28, 2020
ggazzo
ggazzo previously approved these changes Aug 29, 2020
ggazzo
ggazzo previously approved these changes Aug 29, 2020
@sampaiodiego sampaiodiego merged commit a5118fa into develop Aug 29, 2020
@sampaiodiego sampaiodiego deleted the omni/curr-chat-reg branch August 29, 2020 04:17
@sampaiodiego sampaiodiego mentioned this pull request Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants