Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update base image in Dockerfile.rhel #19036

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

andykrohg
Copy link
Contributor

@andykrohg andykrohg commented Sep 27, 2020

Proposed changes

Update base NodeJS image, and remove OS-level workarounds

Issue(s)

Fixes #19035
Tested successfully using https://quay.io/repository/akrohg/rocketchat

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Update base image for Dockerfile.rhel to registry.access.redhat.com/ubi8/nodejs-12

@sampaiodiego
Copy link
Member

@geekgonecrazy are we still using/publishing this container image?

@@ -1,4 +1,4 @@
FROM registry.access.redhat.com/rhscl/nodejs-8-rhel7
FROM registry.access.redhat.com/ubi8/nodejs-12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh.. why this instead of rhscl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ever since ubi was announced last year, we've been advocating for customers and partners to use it as a base in favor of rhscl because ubi images can be freely redistributed without requiring RHEL subscriptions, whereas rhscl ones can't.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! I missed that announcement!

@geekgonecrazy
Copy link
Contributor

@sampaiodiego yes it backs the red hat container registry image. It has similar requirements like the docker official image. Difference of course is required a red hat base

@sampaiodiego sampaiodiego merged commit 9c95435 into RocketChat:develop Dec 22, 2020
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NodeJS version in Dockerfile.rhel (8) out of date
3 participants