Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] UI/UX enhancements in department pages following the design system #19421

Merged
merged 8 commits into from
Nov 18, 2020
Merged

[IMPROVE] UI/UX enhancements in department pages following the design system #19421

merged 8 commits into from
Nov 18, 2020

Conversation

rafaelblink
Copy link
Contributor

Proposed changes

After a research into departments, I've seen that the list and create/edit page are not following the design system of Rocket.chat, so I've did some improvements:

List page:

  • "New" button following design system and translation
  • "Remove" color adjusts
  • Added confirmation modal for remove function
  • Title page translation

Create/edit page:

  • "Back" button following design system
  • Added e-mail validation
  • Fixing margins between fields
  • Fixing validation that you can click on button save only when you've some changes in form
  • Fixing "Save" message when you click on save button for the correct message

Issue(s)

How to test or reproduce

Screenshots

Before

image

image

image

After

image

image

image

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@rafaelblink rafaelblink added this to the 3.9.0 milestone Oct 30, 2020
@rafaelblink rafaelblink changed the title [IMPROVEMENTS] Refactoring departments page to follow design system. [IMPROVEMENTS] Omnichannel - Refactoring departments page to follow design system. Nov 10, 2020
rafaelblink and others added 3 commits November 17, 2020 16:29
@rafaelblink
[IMPROVE] Removing unnecessary margin bottom from EE inputs and depar…
d27a9cc 
…tment margins from form.
@rafaelblink
Merge remote-tracking branch 'origin/omnichannel/departments-improvem…
50c29a1 
…ents' into omnichannel/departments-improvements
@rafaelblink @renatobecker
Update client/omnichannel/departments/DepartmentEdit.js
8bbf578 
Co-authored-by: Renato Becker <renato.augusto.becker@gmail.com>
@renatobecker renatobecker changed the title [IMPROVEMENTS] Omnichannel - Refactoring departments page to follow design system. [IMPROVE] UI/UX improvements in department pages following the design system Nov 17, 2020
@renatobecker renatobecker changed the title [IMPROVE] UI/UX improvements in department pages following the design system [IMPROVE] UI/UX enhancements in department pages following the design system Nov 17, 2020
@renatobecker renatobecker merged commit 21c8c6c into develop Nov 18, 2020
@renatobecker renatobecker deleted the omnichannel/departments-improvements branch November 18, 2020 02:38
gabriellsh added a commit that referenced this pull request Nov 18, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into debo…
c4840be 
…unce_sidebar

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Add support to `replace` operation when using Change Stream (#19579)
  Regression: Room Info maxAgeDefault variable (#19582)
  Regression: Room Info Edit action (#19581)
  [IMPROVE] UI/UX enhancements in department pages following the design system (#19421)
  [IMPROVE] Rewrite Room Info (#19511)
  [IMPROVE] KeyboardShortcuts as React component (#19518)
  [FIX] Regex in "livechat/visitors.search" endpoint to return visitors correctly. (#19577)
  Regression: Fix wrong template on photoswipe (#19575)
  [FIX] UI/UX issues on Omnichannel Managers page (#19410)
  [FIX] Input without label and email ordering missing on Omnichannel Agents page (#19414)
  Regression: Photoswipe not working (#19569)
  [IMPROVE] UI/UX enhancements in Omnichannnel Current Chats page (#19397)
  Regression: Fix Avatar x40 (#19564)
  [NEW] Remove Box props from Avatar component (#19491)
  [NEW] Remove Box dependence from Tag and Badge components (#19467)
@sampaiodiego sampaiodiego mentioned this pull request Nov 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobecker renatobecker renatobecker approved these changes

Assignees
No one assigned
Labels
type: bug type: improvement
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rafaelblink @renatobecker