Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Rewrite contextualbar RoomMembers - InviteUsers #19694

Merged
merged 8 commits into from Nov 30, 2020
Merged

[IMPROVE] Rewrite contextualbar RoomMembers - InviteUsers #19694

merged 8 commits into from Nov 30, 2020

Conversation

dougfabris
Copy link
Member

Proposed changes

Issue(s)

How to test or reproduce

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Hotfix (a major bugfix that has to be merged asap)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Changelog

Further comments

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 1 alert when merging d45ce87 into e2536d3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2020

This pull request introduces 1 alert when merging 76a92e0 into e2536d3 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to property

@ggazzo ggazzo changed the base branch from feat/rewrite-room-members to develop November 30, 2020 13:32
@ggazzo ggazzo marked this pull request as ready for review November 30, 2020 15:08
@ggazzo ggazzo merged commit 451dc84 into develop Nov 30, 2020
@ggazzo ggazzo deleted the feat/rewrite-room-members-invite branch November 30, 2020 15:40
gabriellsh added a commit that referenced this pull request Nov 30, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into head…
ba77cae 
…er_gh

* 'develop' of github.com:RocketChat/Rocket.Chat: (44 commits)
  [IMPROVE] Rewrite contextualbar Room Members - InviteUsers (#19694)
  [IMPROVE] Rewrite contextualbar OTR panel (#19674)
  [FIX] UIKit Modal not scrolling (#19690)
  Bump version to 3.10.0-develop
  Bump version to 3.9.0
  Bump version to 3.9.0-rc.5
  Regression: object-fit for image element and Box margin in AppAvatar component (#19698)
  Bump version to 3.8.2
  [FIX] Room avatar update event doesn't properly broadcast room id (#19684)
  [FIX] Server crash while reading settings for allowed and blocked email domain lists (#19683)
  [FIX] Server crash while reading settings for allowed and blocked email domain lists (#19683)
  [FIX] Room avatar update event doesn't properly broadcast room id (#19684)
  Bump version to 3.9.0-rc.4
  Regression: Fix Custom OAuth 2FA (#19691)
  Update Apps-Engine version (#19702)
  Improve performance of migration 211 (adding mostImportantRole to sessions) (#19700)
  Bump version to 3.9.0-rc.3
  Regression: URL preview problem (#19685)
  Regression: Fix LDAP 2FA not working when Login Fallback is off (#19659)
  Fix permission duplicated error on startup causing CI to halt (#19653)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Dec 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dougfabris @ggazzo