Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fixed Notification-sound volume number in profile settings. #20238

Closed
wants to merge 1 commit into from

Conversation

Darshilp326
Copy link
Contributor

Proposed changes (including videos or screenshots)

Notification-sound volume number can be viewed properly.

Before
Screenshot from 2021-01-17 14-41-04
After
Screenshot from 2021-01-17 14-35-32

Issue(s)

Fixes #20236
Bug Number 3

Steps to test or reproduce

Further comments

Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, thanks for your PR but I don't think this currently fixes the problem, as you can see there is an arrow there:
image
you just positioned the arrow in a different place that we cant see, the fix should be put the arrow in the right place

thanks again

@ggazzo ggazzo changed the title [BUG]Fixed Notification-sound volume number in profile settings. [FIX] Fixed Notification-sound volume number in profile settings. Jan 19, 2021
@Darshilp326
Copy link
Contributor Author

@ggazzo Sorry, I am not able to get your point. Can you explain?

@ggazzo
Copy link
Member

ggazzo commented Jan 22, 2021

look this pr #20310, it is almost right but he put to the wrong side

@sushant52
Copy link
Contributor

sushant52 commented Jan 22, 2021

almost right but he put to the wrong side

@ggazzo Sorry I thought it was the correct position 😅. I have made the changes, tooltip fits perfectly now.

@Darshilp326
Copy link
Contributor Author

Darshilp326 commented Jan 22, 2021

look this pr #20310, it is almost right but he put to the wrong side

Ohh like this.

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@dougfabris
Copy link
Member

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's stale now and it was already fixed in another one.


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

@dougfabris dougfabris closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No one can change profile settings.
6 participants