-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Save user password and email from My Account #20737
Conversation
d40457f
to
5a476d2
Compare
Great to see this fix, as it is really security related, if users can not change their passwords. Also other profile settings (email, avatar image etc) could not be changed. |
const canChangePasswordForOAuth = rcSettings.get('Accounts_AllowPasswordChangeForOAuthUsers'); | ||
if (canChangePasswordForOAuth || user.services?.password) { | ||
// Should be the last check to prevent error when trying to check password for users without password | ||
if (settings.newPassword && rcSettings.get('Accounts_AllowPasswordChange') === true) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove the === true
part of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, this is an old code that was just re-indented, but I agree 👍
Proposed changes (including videos or screenshots)
Issue(s)
Closes #19604
Steps to test or reproduce
Further comments