Mixed client and server code on Storybook #20799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tassoevan
force-pushed
the
perf/mixed-client-server-code
branch
2 times, most recently
from
75821e1
to
48a358c
Compare
tassoevan
force-pushed
the
perf/mixed-client-server-code
branch
from
48a358c
to
1282138
Compare
ggazzo
approved these changes
Feb 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
For Storybook to work, we've mocked all modules under
**/server/, thus making them suitable to hold all code that refers Node.js modules. This implies some duplication, betweenclient/andserver/modules, mediated by modules underlibs/.Issue(s)
Steps to test or reproduce
Further comments