Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Discussion room crashing if not member of parent channel #21310

Merged
merged 4 commits into from Mar 25, 2021
Merged

regression: Discussion room crashing if not member of parent channel #21310

merged 4 commits into from Mar 25, 2021

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@gabriellsh gabriellsh requested a review from a team March 25, 2021 20:56
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 1 alert when merging db82a1c into eb29b03 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

MartinSchoeler
MartinSchoeler approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to resolve the issue

@ggazzo ggazzo merged commit ff9bf84 into develop Mar 25, 2021
@ggazzo ggazzo deleted the reg/room_crash branch March 25, 2021 22:43
@sampaiodiego sampaiodiego mentioned this pull request Apr 3, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@MartinSchoeler MartinSchoeler MartinSchoeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabriellsh @ggazzo @MartinSchoeler