Regression: Permissions missing on new Room Edit and Contact Edit form

[murtaza98]

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

[renatobecker]

The Edit Contact action works like a charm, but the Edit Room action doesn't. This is what I get:

[murtaza98]

The Edit Contact action works like a charm, but the Edit Room action doesn't. This is what I get:

@renatobecker Sorry I wasn't able to reproduce this error. Could you please check again ?
btw, I was able to edit room within the directory as well as chat room

[renatobecker]

@murtaza98 the implementation fixes the issues, however, it's clear that both Contact and Room contextual bar are placed in the wrong folder -> client/omnichannel/directory/.

Since those components are used in different areas of the product, they should be placed in a "global" folder, not inside the "directory" folder.

@rafaelblink please, help us reviewing this PR. Thanks.

[murtaza98]

@murtaza98 the implementation fixes the issues, however, it's clear that both Contact and Room contextual bar are placed in the wrong folder -> client/omnichannel/directory/.

Since those components are used in different areas of the product, they should be placed in a "global" folder, not inside the "directory" folder.

@rafaelblink please, help us reviewing this PR. Thanks.

@renatobecker I've moved out the files. Could you please review it again? Thanks

[renatobecker]

Where are we checking permissions for room editing and contact editing? I didn't find it.
This is how we used to check it on the old version:

https://github.com/RocketChat/Rocket.Chat/blob/develop/app/livechat/client/views/app/tabbar/visitorInfo.js#L184-L189

Also, we can't just add a permission check for rendering the button or not because the user can access the route through the URL, so the permission needs to allow/deny accessing the edit form(room or contact) anyways.

[murtaza98]

@renatobecker For Room i've implemented the same logic as here.

However I'm not sure what permission to use for Contact edit? Should I create a new global permission edit-contacts and by default apply this permission to agents and managers?

[renatobecker]

Should I create a new global permission edit-contacts

edit-omnichannel-contact

and by default apply this permission to agents and managers?

Yes.

[murtaza98]

Should I create a new global permission edit-contacts

edit-omnichannel-contact

and by default apply this permission to agents and managers?

Yes.

Hey @renatobecker, This part is complete

[murtaza98]

@renatobecker I forgot to revert this change in the previous commit. So I'm doing it here

[murtaza98]

Since we don't have a Chat History button in contacts directory, this is no longer needed