-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] If an admin creates a custom status, it will be taken into account #21631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating the code
updating the code
updating the fork
update main branch
updating the branch
Update fork
Upating the fork
Updating fork
Jeanstaquet
changed the title
[FIX] If an admin creates a custom status, it will not be taken into account
[FIX] If an admin creates a custom status, it will be taken into account
Apr 17, 2021
sumukhah
reviewed
Apr 18, 2021
@dougfabris can you review please ? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The admin, can create custom status that should change ours when we use it. But currently when we choose a status created by an admin, it does not change our status. It only displays the status type. If the admin custom status feature exists, it should change our status, otherwise it will be useless.
I've seen the different issues and PRs on this subject, but I think that here we keep what was decided in these PRs, except that we take into account the feature of admin custom status. Now, we can choose admin custom status as well.
So in fact what I did was to awaken a feature already present but not exploited.
Default language version of the app
2021-04-18.15-28-01.mp4
Another language than EN
2021-04-18.15-41-48.mp4
Issue(s)
Fixes #21630
Steps to test or reproduce
Further comments
I have tested with other language versions of the application and it works fine.