Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] If an admin creates a custom status, it will be taken into account #21631

Closed
wants to merge 21 commits into from
Closed

[FIX] If an admin creates a custom status, it will be taken into account #21631

wants to merge 21 commits into from

Conversation

Jeanstaquet
Copy link
Contributor

@Jeanstaquet Jeanstaquet commented Apr 17, 2021

Proposed changes (including videos or screenshots)

The admin, can create custom status that should change ours when we use it. But currently when we choose a status created by an admin, it does not change our status. It only displays the status type. If the admin custom status feature exists, it should change our status, otherwise it will be useless.
I've seen the different issues and PRs on this subject, but I think that here we keep what was decided in these PRs, except that we take into account the feature of admin custom status. Now, we can choose admin custom status as well.
So in fact what I did was to awaken a feature already present but not exploited.

Default language version of the app

2021-04-18.15-28-01.mp4

Another language than EN

2021-04-18.15-41-48.mp4
  • When the admin creates a custom status, if the user chooses it, it will change the user's status, but when they go to a standard status, like 'online' for example, it reset the status of the admin.
  • When the user creates a custom status, if they choose after a standard status, it does not reset their status, it just changes the coloured ball. If the user chooses an admin status while he has his own status, it will reset his status and take the admin's status.

Issue(s)

Fixes #21630

Steps to test or reproduce

Further comments

I have tested with other language versions of the application and it works fine.

@Jeanstaquet Jeanstaquet changed the title [FIX] If an admin creates a custom status, it will not be taken into account [FIX] If an admin creates a custom status, it will be taken into account Apr 17, 2021
@Jeanstaquet
Copy link
Contributor Author

@dougfabris can you review please ? :)

@CLAassistant
Copy link

CLAassistant commented Dec 17, 2021

CLA assistant check
All committers have signed the CLA.

@ggazzo ggazzo added this to the 5.4.0 milestone Nov 2, 2022
@ggazzo ggazzo closed this Nov 22, 2022
@dougfabris dougfabris removed this from the 5.4.0 milestone Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If an admin creates a custom status, it will not be taken into account
7 participants