Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Error getting default agent when routing system algorithm is Auto Selection #22976

Merged

Conversation

renatobecker
Copy link
Contributor

Proposed changes (including videos or screenshots)

When the Omnichannel routing system algorithm is Auto Selection (Community version) an error is raised when getting the default agent. The cause of the issue was a wrong implementation of a callback method.
Another issue has been found and fixed: Guests associated with a department that no longer exists were not routed properly since the routing system was trying to find available agents associated with a department that doesn't exist anymore.

Issue(s)

Steps to test or reproduce

Further comments

@renatobecker renatobecker added this to the 3.18 milestone Aug 19, 2021
KevLehman
KevLehman previously approved these changes Aug 19, 2021
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried on community, autoselection algorithm is no longer returning errors. However, there's still an issue with the routing itself (that afaik, won't be handled in this same PR)

app/livechat/server/hooks/beforeDelegateAgent.js Outdated Show resolved Hide resolved
app/livechat/server/lib/RoutingManager.js Outdated Show resolved Hide resolved
@renatobecker
Copy link
Contributor Author

Suggestions applied.

KevLehman
KevLehman previously approved these changes Aug 20, 2021
@KevLehman KevLehman requested a review from ggazzo August 20, 2021 18:47
@ggazzo ggazzo merged commit a6cc4b0 into develop Aug 23, 2021
@ggazzo ggazzo deleted the omnichannel/fix-default-agent-auto-selection-algorithm branch August 23, 2021 12:39
@renatobecker renatobecker modified the milestones: 3.18, 3.17.2 Aug 26, 2021
@sampaiodiego sampaiodiego mentioned this pull request Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants