-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Error getting default agent when routing system algorithm is Auto Selection #22976
Merged
ggazzo
merged 7 commits into
develop
from
omnichannel/fix-default-agent-auto-selection-algorithm
Aug 23, 2021
Merged
[FIX] Error getting default agent when routing system algorithm is Auto Selection #22976
ggazzo
merged 7 commits into
develop
from
omnichannel/fix-default-agent-auto-selection-algorithm
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
previously approved these changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried on community, autoselection algorithm is no longer returning errors. However, there's still an issue with the routing itself (that afaik, won't be handled in this same PR)
ggazzo
requested changes
Aug 20, 2021
Suggestions applied. |
KevLehman
previously approved these changes
Aug 20, 2021
ggazzo
approved these changes
Aug 23, 2021
ggazzo
deleted the
omnichannel/fix-default-agent-auto-selection-algorithm
branch
August 23, 2021 12:39
Merged
sampaiodiego
pushed a commit
that referenced
this pull request
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When the Omnichannel routing system algorithm is Auto Selection (Community version) an error is raised when getting the default agent. The cause of the issue was a wrong implementation of a callback method.
Another issue has been found and fixed: Guests associated with a department that no longer exists were not routed properly since the routing system was trying to find available agents associated with a department that doesn't exist anymore.
Issue(s)
Steps to test or reproduce
Further comments