Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] Remove old migrations up to version 2.4.14 #23277

Merged
merged 7 commits into from Sep 23, 2021

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

To update to version 4.0.0 you'll need to be running at least version 3.0.0, otherwise you might loose some database migrations which might have unexpected effects.

This aims to clean up the code, since upgrades jumping 2 major versions are too risky and hard to maintain, we'll keep only migration from that last major (in this case 3.x).

Another changes included in this PR:

  • Removed old Migrations class - functionality remains the same though
    • New migrations should use addMigration() instead of Migrations.add()
  • Migrations code re-written in TS

Still missing some code clean up.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team September 23, 2021 14:59
@RocketChat RocketChat deleted a comment from lgtm-com bot Sep 23, 2021
@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2021

This pull request fixes 4 alerts when merging 650005a into 88b2698 - view on LGTM.com

fixed alerts:

  • 3 for Insecure randomness
  • 1 for Useless assignment to local variable

@ggazzo ggazzo closed this Sep 23, 2021
@ggazzo ggazzo reopened this Sep 23, 2021
@sampaiodiego sampaiodiego merged commit 74e0319 into develop Sep 23, 2021
@sampaiodiego sampaiodiego deleted the improve-migration branch September 23, 2021 18:29
@geekgonecrazy
Copy link
Member

geekgonecrazy commented Sep 24, 2021

@debdutdeb This one is one you will want to pay attention to from snap perspective. Gotta make sure every snap update goes through a 3.x version no matter what they chose to do by staying back a version on an old track like 1.x or 2.x 🙏

[edit]
Also brought up internal but maybe we shouldn't even start if current migration is older then the latest one here?

@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants