New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Play selected notification sounds as preview while changing sound settings #24205
[IMPROVE] Play selected notification sounds as preview while changing sound settings #24205
Conversation
…changing the volume
@dougfabris @sampaiodiego Can you please take a look ? |
Amazing work.🔥 |
@debdutdeb Can you please take a look at this again as it is open for a while now and haven't got any updates on it? |
Is this PR still actual for the community? |
Codecov Report
@@ Coverage Diff @@
## develop #24205 +/- ##
============================================
+ Coverage 32.32% 43.72% +11.39%
============================================
Files 626 791 +165
Lines 12481 15392 +2911
Branches 1836 2131 +295
============================================
+ Hits 4035 6730 +2695
- Misses 8248 8375 +127
- Partials 198 287 +89
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Currently no sound plays while changing the notification sound settings or adjusting the volume which does not seem to be a good user experience as the user cannot preview the changes.
This PR enables the user to listen the selected sound at the selected volume .
Check out this video for the proposed changes (Turn on the volume)
notification-sounds.mp4
Issue(s)
Steps to test or reproduce
Further comments