Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Broken links in search bar #24222

Closed

Conversation

himanshu-malviya15
Copy link
Contributor

@himanshu-malviya15 himanshu-malviya15 commented Jan 20, 2022

This is fixed using a more narrow regex search, added precise regex to check and replace the searched text with a highlight.

Before :

Before.mp4

After :

After.mp4

Issue(s)

Closes #24198

@himanshu-malviya15
Copy link
Contributor Author

@dougfabris Please review this PR.

@TBG-FR
Copy link
Contributor

TBG-FR commented Sep 14, 2022

#20878 should fix this (and not only on links (href) but also on emojis and users, but it's still awaiting approval/review 😅

@dougfabris dougfabris changed the title [FIX]: Broken links in search bar [FIX] Broken links in search bar Nov 3, 2022
@dougfabris
Copy link
Member

dougfabris commented Feb 14, 2023

Closing this one because it's already fixed due to a recent refactor on component here: #28001.
Thanks for the contribution!

@dougfabris dougfabris closed this Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Broken link in search
4 participants