Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Message search changes #28001

Merged
merged 16 commits into from Feb 14, 2023
Merged

Chore: Message search changes #28001

merged 16 commits into from Feb 14, 2023

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Feb 13, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Fixes #18770
Fixes #24198
Fixes #23285

Steps to test or reproduce

Further comments

Additionally, it drops the message template in favor of React components.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #28001 (1761dfa) into develop (c9fd3c5) will increase coverage by 2.47%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28001      +/-   ##
===========================================
+ Coverage    41.70%   44.18%   +2.47%     
===========================================
  Files          826      787      -39     
  Lines        16948    15741    -1207     
  Branches      2074     1960     -114     
===========================================
- Hits          7069     6955     -114     
+ Misses        9601     8511    -1090     
+ Partials       278      275       -3     
Flag Coverage Δ
e2e 44.18% <40.00%> (+2.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title Chore: refactor/message-search Chore: Message search changes Feb 14, 2023
@tassoevan tassoevan marked this pull request as ready for review February 14, 2023 13:23
@tassoevan tassoevan requested review from a team as code owners February 14, 2023 13:23
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 14, 2023
@kodiakhq kodiakhq bot merged commit 2e99a20 into develop Feb 14, 2023
@kodiakhq kodiakhq bot deleted the refactor/message-search branch February 14, 2023 13:40
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
2 participants