Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.5.4 #24938

Merged
merged 2 commits into from Mar 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .docker/Dockerfile.rhel
@@ -1,6 +1,6 @@
FROM registry.access.redhat.com/ubi8/nodejs-12

ENV RC_VERSION 4.5.3
ENV RC_VERSION 4.5.4

MAINTAINER buildmaster@rocket.chat

Expand Down
27 changes: 26 additions & 1 deletion .github/history.json
Expand Up @@ -71688,6 +71688,31 @@
]
}
]
},
"4.5.4": {
"node_version": "14.18.3",
"npm_version": "6.14.15",
"apps_engine_version": "1.31.0",
"mongo_versions": [
"3.6",
"4.0",
"4.2",
"4.4",
"5.0"
],
"pull_requests": [
{
"pr": "24930",
"title": "[FIX] Force name to string",
"userLogin": "geekgonecrazy",
"milestone": "4.5.4",
"contributors": [
"geekgonecrazy",
"web-flow",
"pierre-lehnen-rc"
]
}
]
}
}
}
}
2 changes: 1 addition & 1 deletion .snapcraft/resources/prepareRocketChat
@@ -1,6 +1,6 @@
#!/bin/bash

curl -SLf "https://releases.rocket.chat/4.5.3/download/" -o rocket.chat.tgz
curl -SLf "https://releases.rocket.chat/4.5.4/download/" -o rocket.chat.tgz

tar xf rocket.chat.tgz --strip 1

Expand Down
2 changes: 1 addition & 1 deletion .snapcraft/snap/snapcraft.yaml
Expand Up @@ -7,7 +7,7 @@
# 5. `snapcraft snap`

name: rocketchat-server
version: 4.5.3
version: 4.5.4
summary: Rocket.Chat server
description: Have your own Slack like online chat, built with Meteor. https://rocket.chat/
confinement: strict
Expand Down
19 changes: 19 additions & 0 deletions HISTORY.md
@@ -1,4 +1,23 @@

# 4.5.4
`2022-03-24 · 1 🐛 · 2 👩‍💻👨‍💻`

### Engine versions
- Node: `14.18.3`
- NPM: `6.14.15`
- MongoDB: `3.6, 4.0, 4.2, 4.4, 5.0`
- Apps-Engine: `1.31.0`

### 🐛 Bug fixes


- Force name to string ([#24930](https://github.com/RocketChat/Rocket.Chat/pull/24930))

### 👩‍💻👨‍💻 Core Team 🤓

- [@geekgonecrazy](https://github.com/geekgonecrazy)
- [@pierre-lehnen-rc](https://github.com/pierre-lehnen-rc)

# 4.5.3
`2022-03-21 · 2 🚀 · 8 🐛 · 1 🔍 · 5 👩‍💻👨‍💻`

Expand Down
2 changes: 1 addition & 1 deletion app/meteor-accounts-saml/server/lib/Utils.ts
Expand Up @@ -434,7 +434,7 @@ export class SAMLUtils {
}
const email = this.getProfileValue(profile, userDataMap.email);
const profileUsername = this.getProfileValue(profile, userDataMap.username, true);
const name = this.getProfileValue(profile, userDataMap.name);
const name = this.getProfileValue(profile, userDataMap.name, true);

// Even if we're not using the email to identify the user, it is still mandatory because it's a mandatory information on Rocket.Chat
if (!email) {
Expand Down
2 changes: 1 addition & 1 deletion app/meteor-accounts-saml/server/lib/parsers/Response.ts
Expand Up @@ -403,7 +403,7 @@ export class ResponseParser {

const key = attributes[i].getAttribute('Name');
if (key) {
SAMLUtils.log(`Name: ${attributes[i]}`);
SAMLUtils.log(`Attribute: ${attributes[i]} has ${values.length} value(s).`);
SAMLUtils.log(`Adding attribute from SAML response to profile: ${key} = ${value}`);
profile[key] = value;
}
Expand Down
2 changes: 1 addition & 1 deletion app/utils/rocketchat.info
@@ -1,3 +1,3 @@
{
"version": "4.5.3"
"version": "4.5.4"
}
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,7 +1,7 @@
{
"name": "Rocket.Chat",
"description": "The Ultimate Open Source WebChat Platform",
"version": "4.5.3",
"version": "4.5.4",
"author": {
"name": "Rocket.Chat",
"url": "https://rocket.chat/"
Expand Down