Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Unify voip streams into single stream #25108

Merged
merged 8 commits into from
May 23, 2022

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman changed the title Unify voip streams into single stream [IMPROVE] Unify voip streams into single stream Apr 8, 2022
@KevLehman
Copy link
Contributor Author

@d-gubert @amolghode1981 this would be a good addition to the release and forgot to put on milestone 😬 pls don't kill me

@KevLehman KevLehman added this to the 4.8.0 milestone May 4, 2022
Copy link
Contributor

@amolghode1981 amolghode1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some confusion. Hence adding a generic comment. The title says that "Unify voip streams into single stream". When I saw the implementation of "notifyUserInThisInstance", it is using streamUser (

notifyUserInThisInstance(userId: string, eventName: string, ...args: any[]): void {
)

Isnt it a single stream? Or Am I missing something here?

amolghode1981
amolghode1981 previously approved these changes May 20, 2022
Copy link
Contributor

@amolghode1981 amolghode1981 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review was already done and changes were accepted.
Accepting this post conflict resolution.

@KevLehman KevLehman merged commit 4bc080b into develop May 23, 2022
@KevLehman KevLehman deleted the improve/voip-streams-unify branch May 23, 2022 19:00
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants