Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0 #26333

Merged
merged 367 commits into from
Jul 21, 2022
Merged

Release 5.0.0 #26333

merged 367 commits into from
Jul 21, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented Jul 21, 2022

2022-07-22 · 14 ️️️⚠️ · 33 🎉 · 20 🚀 · 110 🐛 · 389 🔍 · 63 👩‍💻👨‍💻

Engine versions

  • Node: 14.19.3
  • NPM: 6.14.17
  • MongoDB: 4.2, 4.4, 5.0

⚠️ BREAKING CHANGES

  • Chore: Remove unused tokenpass integration code (#25831)

  • Deactivated team members are added to auto-join rooms (#25016)

    • Do not add deactivated users to auto-join rooms.
  • Remove Blockstack authentication (#25649)

    Blockstack authentication is broken and is preventing some dependencies to be up to date. As a migration to Stacks authentication is not trivial, we've opted for removing the authentication service.

  • Remove RDStation integration (#25774)

  • Remove show message in main thread preference (#26002)

    This PR removes the confusion between the show message in main thread and the function also to send to channel. In the past, we used the show message in main thread as a solution to help users to understand the thread feature, as this feature is now mature enough there's no reason to maintain this preference.

    Send the thread message to the main channel or just inside of the thread, should be a decision from the user where the function also send to channel appears. Because of that, and because of a bunch of requests and issues we received, we're introducing a new preference also send thread to channel where users will be able to decide the behavior of the checkbox.

    image

    Now there are three behavior options

    • Default: when it unchecks after sending the first message
    • Always: stay checked for all messages
    • Never: stay unchecked for all messages
  • Remove support to old MongoDB versions (#26098)

    As per MongoDB Lifecycle Schedules (https://www.mongodb.com/support-policy/lifecycles) we're removing official support to MongoDB versions 3.6 and 4.0 that have already reached end-of-life.

    As MongoDB 4.2 was a "supported" version before Rocket.Chat 5.0, we'll continue supporting it, but will be flagged as deprecated. We recommend upgrading to MongoDB 4.4+.

    Here are official docs on how to upgrade to some of the supported versions:

  • remove unused endpoints and restify others (#25889)

  • Remove webRTC for channels/dm/groups (#26225)

  • Suspend push notifications when login token is invalidated (#20913 by @g-thome)

    link the auth token to the push token

  • Upgrade to version 5.0 can be done only from version 4.x (#26100)

  • use urlParams on omnichannel/agent/extension/ (#25982)

  • use urlParams on omnichannel/agent/extension/ (#25874)

  • use urlParams on omnichannel/agent/extension/" (#25980)

  • VideoConference (#25570)

In this PR we're deprecating the Video Conference functionality from the core of the application and introducing a new video conference flow:

Now the video conference feature will be agnostic so you'll be able to set the provider such as Jisti and BBB as apps from our marketplace:

Video conferences settings are now global, allowing you to set the default provider

[Enterprise Features]

  • Enterprise Providers: Google Meet and Pexip

  • Calls List

  • Ringing function for direct messages

🎉 New features

  • APPS: Allow apps to modify a subset of global settings (#25913)

  • APPS: Allow dispatchment of actions from input elements (#25949)

    This allows for apps receiving block actions when a user types on a plain text input field or selects an item from the static. A debounce of 700 ms is done when listening for typing action so the app is not flooded with actions.

    input-element-block-action.mp4
  • APPS: Allowing apps to register authenticated routes (#25937)

    Adds adaptations that allow apps to declare an API endpoint that requires authorization from Rocket.Chat prior to executing

  • ENTERPRISE: Device Management (#25791)

  • ENTERPRISE: Introducing dial pad component into sidebar, calls table, contextual bar (#26081)

    This PR adds a new call button that can be used from Sidebar & Contact Center. This also enables Omnichannel agents to make outbound calls from within Rocket.Chat.

    Depending on your server and call server configuration, you can do international calling, national and domestic calling.

    The buttons on Contact Center allows an agent to call an existing number without having to type the number again.

  • Ability for RC server to check the business hour for a specific department (#25436)

  • Accept quoted slash command arguments (#11744 by @Hudell)

  • Add expire index to integration history (#25087)

  • Add new app events for pin, react and follow message (#25337)

  • Add new events after user login, logout and change his status (#25234)

  • Add option to show mentions badge when show counter is disabled (#25329)

  • Add user events for apps (#25165)

  • Adding app button on user dropdown (#25326)

  • Alpha Matrix Federation (#23688)

    Experimental support for Matrix Federation with a Bridge

    Quick.Example.showing.Matrix.org.mp4
  • Colors Palette - Buttons (#25626)

  • Community Edition Watermark (#25844)

  • Create releases tab in the marketplace app info page (#25965)

    Added a Releases tab to the app info page of installed marketplace apps. This tab will show all the released versions of a given app with its version number, release date in humanized form, and the changelog of this given release with the information provided by the publisher, this changelog accepts and renders markdown. Also refactored some component names and logic for maintainability reasons.
    Demo gif:
    app-releases-tab-final

  • Create Team with a member list of usernames (#25868)

  • Enable outbound calling for EE ([NEW] Enable outbound calling for EE #25843) (#25960)

  • Engagement Metrics - Phase 2 (#25505)

    Add the following new statistics (metrics):

    • Total Broadcast rooms
    • Total rooms with an active Livestream;
    • Total triggered emails;
    • Total subscription roles;
    • Total User Roles;
    • Total uncaught exceptions;
    • homeTitleChanged: boolean value to indicate whether the Layout_Home_Title setting has been changed;
    • homeBodyChanged: boolean value to indicate whether the Layout_Home_Body setting has been changed;
    • customCSSChanged: boolean value to indicate whether the theme-custom-css setting has been changed;
    • onLogoutCustomScriptChanged: boolean value to indicate whether the Custom_Script_On_Logout setting has been changed;
    • loggedOutCustomScriptChanged: boolean value to indicate whether the Custom_Script_Logged_Out setting has been changed;
    • loggedInCustomScriptChanged: boolean value to indicate whether the Custom_Script_Logged_In setting has been changed;
    • matrixBridgeEnabled: boolean value to indicate whether the Matrix bridge has been enabled;
  • Expand Apps Engine's environment variable allowed list (#23870 by @cuonghuunguyen)

  • Federation (Alpha Stabilization) (#25457)

  • Fuselage ToastBar (#25583)

    Kapture 2022-05-20 at 14 50 19

  • Get user's preferred language via apps (#25514)

  • Marketplace new app details page (#24711)

    Change the app details page layout for the new marketplace UI. General Task: MKP12 - New UI - App Detail Page

    MKP12 - Tab Navigation

    New tab navigation layout for the app details page. Now the app details page is divided into three sections, details, logs, and settings, that can each be accessed through a Tabs fuselage component.

    Demo gif:
    tab_navigation_demo_gif

    MKP12 - Header

    Implemented a new header for the marketplaces app details page.
    -Changed the size of the app name;
    -Implemented the app description field on the header;
    -Changed the "metadata" section of the header(The part with the version and author information) now it also shows the last time the app was updated;
    -Created a chip that will show when an app is part of one or more bundles and inform which are the bundles;
    -Implemented a tooltip for the bundle chips;
    -Created a new button + data badge component to substitute the current App Status;
    -Changed the title of the "purchase button". Now it shows different text based on the "purchase type" of the app;
    -Created a new Pricing & Status display which shows the price when the app is not bought/installed and shows the app status(Enabled/Disabled) when it is bought/installed;
    -Changed the way the tabs are rendered, now if the app is not installed(and consequently doesn't have logs and settings tab) it will not render these tabs;

    Demo gif:
    new-header-gif

    MKP12 - Configuration Tab

    Delivered together with the tab-navigation task. Changed the app settings from the details of the app to the new settings tab.
    Demo image:
    New configuration tab

    MKP12 - Log Tab

    Changed the place of the app logs from the page to the new logs tab. Also changed some styles of the logs accordions to fit better with the new container.

    Before:
    Before

    After
    After

    MKP12 - Page Header

    Changed the design for the page header of the app details page from a title on the left with a save and back button on the right to a back arrow icon on the left side of the title with the save button still on the right. Also changed the title of the page from App details to Back.
    Edit: After some design reconsideration, the page title was changed to App Info.
    Demo gif:
    new_page_header_app_details

    MKP12 - Detail Tab

    Implemented markdown on the description section of the app details page, now the description will show the detailedDescription.rendered (as rendered JSX) information in case it exists and show the description (a.k.a. short description) information in case it doesn't. Unfortunately, as of right now no app has a visual example of a markdown description and because of that, I will not be able to provide a demo image/gif for this PR.

    MKP12 - Slider Component

    Created an image carousel component on the app details page. This component receives images from the apps/appId/screenshots endpoint and shows them on the content section of the app details of any apps that have screenshots registered, if the app has no screenshots it simply shows nothing where the carousel should be. This component is complete with keyboard arrow navigation on the "open" carousel, hover highlight on the carousel preview and close on esc press.
    Demo gif:
    new_carousel_component

  • Marketplace security tab app info page (#25739)

    Created a new security tab for installed apps that displays information related to the given app security policies, terms of services, and necessary permissions for the use of the app.
    Demo gif:
    privacy-tab

  • Matrix Federation UX improvements (#25847)

  • Message Template React Component (#23971)

    Complete rewrite of the messages component in react. Visual changes should be minimal as well as user impact, with no break changes (unless you've customized the blaze template).

    Screen Shot 2022-04-05 at 11 14 18
    In case you encounter any problems, or want to compare, temporarily it is possible to use the old version

    image
  • New button for network outage (#25499)

    When network outage happens it should be conveyed to the user with special icon. This icon should not be clickable.
    Network outage handling is handled in https://app.clickup.com/t/245c0d8 task.

  • New stats rewrite (#25078 by @ostjen)

    Add the following new statistics (metrics):

    • Total users with TOTP enabled;

    • Total users with 2FA enabled;

    • Total pinned messages;

    • Total starred messages;

    • Total email messages;

    • Total rooms with at least one starred message;

    • Total rooms with at least one pinned message;

    • Total encrypted rooms;

    • Total link invitations;

    • Total email invitations;

    • Logo change;

    • Number of rooms inside teams;

    • Number of default (auto-join) rooms inside teams;

    • Number of users created through link invitation;

    • Number of users created through manual entry;

    • Number of imported users (by import type);

  • Star message, report and delete message events (#25383)

  • Use setting to determine if initial general channel is needed (#25441 by @felipe-menelau)

    • Adds flag responsible for overwriting #general channel creation
  • VoIP Input/Output Device Selection (#25966)

🚀 Improvements

  • ENTERPRISE: Allow mapping LDAP groups to multiple RC roles (#23849)

    • Add support to mapping LDAP groups to multiple roles (by specifying arrays in the "User Data Group Map" enterprise setting.
  • Add OTR Room States (#24565)

    Earlier OTR room uses only 2 states, we need more states to support future features.
    This adds more states for the OTR contextualBar.

    • Expired
    Screen Shot 2022-04-20 at 13 55 52
    • Declined
    Screen Shot 2022-04-20 at 13 49 28
    • Error
    Screen Shot 2022-04-20 at 13 55 26
  • Add tooltip to sidebar room menu (#24405 by @Himanshu664)

  • add warnings for federation setup (#25684)

  • Added MaxNickNameLength and MaxBioLength constants (#25231 by @aakash-gitdev)

  • Added tooltip options for message menu (#24431 by @Himanshu664)

  • Avoid using omnichannel-queue collection (#25491)

  • Differ Voip calls from Incoming and Outgoing (#25643)

    Updated this column and its respective endpoints to support inbound/outfound call definitions
    image

  • Expand the feature set of the new message rendering (#25970)

    • Everything inside a new package (@rocket.chat/gazzodown);

    • KaTeX support;

    • Highlighted Words support;

    • Emoji rendering expanded;

    • Code rendering fixed

  • Fix multiple bugs with Matrix bridge (#25318)

  • Improve active/hover colors in account sidebar (#25024 by @Himanshu664)

  • Moved call hold/unhold to EE (#26007)

    This PR adds a restriction, enabling the feature to hold/unhold calls only for Enterprise Edition users.

  • Moved call wrap up modal to EE (#25875)

    This PR adds a restriction, enabling the feature to display the call wrap up modal only for Enterprise Edition users.

  • New admin settings Page (#25439)

    Screen Shot 2022-05-09 at 11 31 58

  • Pass allowDiskUse to channel aggregations on engagement dashboard (#22374)

  • Performance for some Omnichannel features (#25217)

  • Refactor + unit tests for federation-v2 (#25680)

    The main goal for this PR is to add the ability to add tests in our current federation-v2 implementation.
    In this PR, I've added only unit tests (80%), but the goal is to add other kinds of tests in the near future.

    Also, I've created a diagram to show how this refactor was done, and how is the structure of the code

    image

  • Rename upgrade tab routes (#25097)

    Change 'upgrade tab' routes names from camelCase ('goFullyFeatured') to kebab-case ('go-fully-featured') due to URL naming consistency. Changed types, main function and test.

  • Unify voip streams into single stream (#25108)

  • VoIP admin page cleanup: remove unused settings (#25993)

    https://app.clickup.com/t/2n4m61m

🐛 Bug fixes

  • You and @yourUsername reacted withtitle on reactions (#25733)

  • Access issue on chat.getThreadsList (#25750)

  • AccountBox checks for condition (#25708)

  • Add katex render to new message react template (#25239)

  • Add open user card to user avatar (#25445)

  • Add reaction not working in legacy messages (#25222)

  • Added invalid password error message (#24714 by @Himanshu664)

  • Adjust email label in Setup Wizard i18n files (#25260)

    • remove 'Company' label on onboarding email keys in certain languages
  • AgentOverview analytics wrong departmentId parameter (#25073 by @paulobernardoaf)

    When filtering the analytics charts by department, data would not appear because the object:

    {
    value: "department-id",
    label: "department-name"
    }

    was being used in the departmentId parameter.

    • Before:
      image

    • After:
      image

  • AgentsPage pagination (#25820)

  • allow only livechat-agents to be contact manager for any omnichannel contact (#25451)

  • Append path To Route For Custom Emoji (#24379)

  • Attachments and OEmbed margins (#25713)

  • Broken Omnichannel>Agents page (#25731)

  • Bump meteor-node-stubs to version 1.2.3 (#25669 by @Sh0uld)

    With meteor-node-stubs version 1.2.3 a bug was fixed, which occured in issue Web access connection problems since upgrade 4.6.3 -> 4.7.0 #25460 and probably 4.7.0 and 4.7.1 - web clients do not work, mobile clients work #25513 (last one not tested).
    For the issue in meteor see: Uncaught Error: Cannot find module 'stream' with node stubs 1.1.0 meteor/meteor#11974

  • Change form body parameter charset to UTF-8 to fix issue 4.7.0 regression | Files consisting of unicode characters are saved with a broken name. #25456 (#25673 by @divinespear)

    since mscdex/busboy 1.5.0, new option named defParamCharset for form body parameter encoding is added with default value latin1, so unicode filenames are broken since 4.7.0.

    Screenshot from 2022-05-28 16-26-06

  • Change NPS Vote identifier + nps index to unique (#25423)

  • Click to join button Jitsi Call (#25569)

    Added ToolboxProvider to MessageListProvider and fixed actionLink.js open function exec

  • Client disconnection on network loss (#25170)

    Agent gets disconnected (or Unregistered) from asterisk in multiple ways. The goal is that agent should remain online
    unless agent explicitly logs off.
    Agent can stop receiving calls in multiple ways due to network loss. Network loss can happen in following ways.

    1. User tries to switch the network. User experiences a glitch of disconnectivity. This can be simulated by turning the network off
      in the network tab of chrome's dev tool. This can disconnect the UA if the disconnection happens just before the registration refresh.

    2. Second reason is when computer goes in sleep mode.

    3. Third reason is that when asterisk is crashed/in maintenance mode/explicitly stopped.

    Solution:
    The idea is to detect the network disconnection and start the start the attempts to reconnect.
    The detection of the disconnection does not happen in case#1. The SIPUA's UserAgent transport does not
    call onDisconnected when network loss of such kind happens. To tackle this problem, window's online and offline event handlers are
    used.

    The number of retries is configurable but ideally it is to be kept at -1. Whenever disconnection happens, it should keep on trying to
    reconnect with increasing backoff time. This behaviour is useful when the asterisk is stopped.

    When the server is disconnected, it should be indicated on the phone button.

  • Client-generated sort parameters in channel directory (#25768 by @BenWiederhake)

  • Close room when dismiss wrap up call modal (#25056)

  • Custom emoji reaction size (#25393)

  • Custom sound error toast messages (#24515 by @Himanshu664)

  • Deactivating user breaks if user is the only room owner (#24933 by @sidmohanty11)

    Before

    deactivating-user-breaks.mp4

    After

    fix.deactivating-user-breaks-room-with-no-owner.mp4
  • Desktop notification on multi-instance environments (#25220)

  • Direct Reply (#22588)

  • Discussion alphabetical ordering (#25788)

    Added a validation in the prop used for sorting (loweCaseName) checking for a prop that only exists in discussions (prid)

  • Dynamic load matrix is enabled and handle failure (#25495)

  • End call button disappearing when on-hold (#24936)

  • Error "numRequestsAllowed" property in rateLimiter for REST API endpoint when upgrading (#26058)

  • Failure to update Integration History index (#25473)

  • Fix max-width message block (#25686)

  • Fix prom-client new promise usage (#25781)

  • fixes HTML sanitizing error. (#25410)

    If the user sent a HTML message over our product to a livechat user the HTML would get rendered on the message box, this prevents it from happening.

  • Fixing app contextual bar functionality (#25615)

  • Fixing Network connectivity issues with SIP client. (#25391)

    The previous PR [FIX] Client disconnection on network loss #25170 did not handle the issues completely.
    This PR is expected to handle

    1. Clearing call related UI when the network is disconnected or switched.

    2. Do clean connectivity. There were few issues discovered in earlier implementation. e.g endpoint would randomly
      get disconnected after a while. This was due to the fact that the earlier socket disconnection caused the
      removal of contact on asterisk. This should be fixed in this PR.

    3. This PR contains a lot of logs. This will be removed before the final merge.

  • FormData uploads not working (#25069)

  • Full error message is visible (#24856 by @Himanshu664)

  • getUserMentionsByChannel method room permission (#25748)

  • Importer fails to download files from URLs with query string params (#25934)

  • Importer files are unnecessarily transferred over the network. (#25919)

  • Incorrect websocket url in livechat widget (#25261)

  • Initial members value on Create Channel Modal (#26000)

    before

    Screen Shot 2022-06-24 at 11 58 22

    after

    Screen Shot 2022-06-24 at 11 59 38

  • Initial User not added to default channel (#25544)

    If injecting initial user. The user wasn’t added to the default General channel

  • Integrations avatar attribute misuse (#25283)

  • Invitation links don't redirect to the registration form (#25082)

  • Kebab menu clicking issue (#25869)

  • LDAP sync removing users from channels when multiple groups are mapped to it (#25434)

  • Members selection field on creating team modal (#25871)

    • Fix: add members breaking when searching users

    image

  • Message menu action not working on legacy messages. (#25148)

  • Message menu dropdown not working on Mobile Web (#25616)

  • Message preview not available for queued chats (#25092)

  • Messages spacing (#25631)

    Adding sequential prop to Message component from Fuselage

  • Misaligned username on Room Info card for omnichannel chats (#25331)

  • Not showing edit message button when blocking edit after N minutes (#25724 by @matthias4217)

    Previously, in Rocketchat 4.7.0 and later, as mentioned in 4.7.0 regression: edit button not displayed in the first minute after sending a new message #25478, the edit button was not displayed on the interface in the minute after having sent a message. This is now fixed : messages can be edited right after sending them.

  • NPS never finishing sending results (#25067)

  • One of the triggers was not working correctly (#25409)

  • Ordered and unordered list styles, Line breaks. (#25494)

    Also removed the message.md cache from server, since changes in the parser might break messages in the future (and will in this specific case).

  • Pinned Message display cutting off information (#25535)

  • Prevent federation crash on invite users as a non-owner user (#25683)

  • Prevent sequential messages edited icon to hide on hover (#24984)

    before

    Screen Shot 2022-03-29 at 13 35 56

    after

    Screen Shot 2022-03-29 at 11 48 05
  • Proxy settings being ignored (#25022)

    Modify Meteor's HTTP.call to add back proxy support

  • Quote message spacing (#25613)

  • Read receipts show with color gray when not read yet (#25244)

  • Read receipts showing before message read (#25216)

  • Remove 'total' text in admin info page (#25638)

    • Remove initial 'total' text from rooms and messages groups in the admin info page

    • Add 'total' before 'rooms' and 'messages' title on the same section. To use the new 'Total Rooms', was created a new key in the en.i18n.json file.

  • Remove duplicated icon bell when is thread main message (#26051)

  • Remove duplicated property _USERNAMES from createDirectRoom.ts (#26087)

    This pull request removes the duplicated property _USERNAMES from apps/meteor/app/lib/server/functions/createDirectRoom.ts, using only the existing property roomInfo.usernames.

  • Removing user also removes them from Omni collections (#25444)

  • Replace encrypted text to Encrypted Message Placeholder (#24166)

    before

    image

    after

    Screenshot 2022-01-13 at 8 57 47 PM
  • Reply button behavior on broadcast channel (#25175)

    Hide reply button for the user that sent the message

  • room creation fails if app framework is disabled (#25200)

  • Rooms' names turn lower case on CSV import (#24612)

    • Change 'Settings' import to not get cached configs

    • Remove update UI_Allow_room_names_with_special_chars value

  • Sanitize customUserStatus and fix infinite loop (#25449)

    Additional improves:

    • usage of RHF to avoid unnecessary Add and Edit components separately and form validation

    • usage of GenericTableV2 and some hooks to avoid unnecessary code

    • fix IUserStatus type

    • improves in UI design

    • improves empty and loading state

    • improves files structure

    [LOOP ERROR ATTACHMENT]
    Screen Shot 2022-05-09 at 19 42 53

  • Sanitize styles in message (#25744)

  • Settings listeners not receiving overwritten values from env vars (#25448)

  • Settings not being overwritten to their default values (#25891)

  • Showing Blank Message Inside Report (#25007)

    Desktop.2022.03.31.-.15.58.05.02.mp4
  • sidebar colors (#25987)

  • Sort by scope or creation date not working on canned responses list (#25475)

  • Spotlight results showing usernames instead of real names (#25471)

  • Thread Message Preview (#25709)

  • Too many watchers in dev environment. (#25930)

  • Toolbox hiding under contextual bar (#25237)

  • toolbox menu behind thread component (#25925)

  • UI/UX issues on Live Chat widget (#25407)

  • Unable to close chats when comments is disabled (#26057)

    Fixes Omnichannel can´t close from Agent #25954

  • Unable to see channel member list by authorized channel roles (#25412)

  • Undefined headers on API Client (#26083)

  • Unnecessary padding on teams channels footer (#25712)

    before

    after

  • Update chartjs usage to v3 (#25873)

  • Update import from csv-parse (#25872)

    This PR updates the importing of csv-parse because the used method wasn't working anymore, we were receiving the following error:

    error: "this.csvParser is not a function"

  • Update subscription on update team member (#25855)

    Added update to subscription when a team member is updated on teams.updateMember

  • Upgrade tab loader in incorrect position (#25398)

    • Add invisible prop to iframe when loading state is active.
  • Upgrade Tab showing for a split second (#25050)

  • Use correct room property for call ended at (#24932)

  • useCurrentChatTags is not a function (#25604)

  • User abandonment setting was not working doe to failing event hook (#25520)

    A setting watcher and the query for grabbing abandoned chats were broken, now they're not.

  • User avatar reseting and getting random image (#25603)

    • fixes user avatar not being saved after editing the user profile issue

    • fixes user avatar not getting another user picture due to database deletion error

  • user status Offline misnamed as Invisible in Custom Status edit dropdown menu (#24796 by @Kunalvrm555)

  • User's with non-agent role shown on voip agent association model (#25682)

  • UserAutoComplete not rendering UserAvatar correctly (#25055)

    before

    Screen Shot 2022-04-04 at 16 50 21

    after

    Screen Shot 2022-04-04 at 16 49 00

  • UserCard sanitization (#25089)

    • Rewrites the component to TS

    • Fixes some visual issues

    before

    Screen Shot 2022-04-07 at 00 23 11

    after

    Screen Shot 2022-04-07 at 00 07 13

  • Users without the view-other-user-info permission can't use the users.list endpoint (#26050)

    This PR fix the query when a normal users access users.list

  • Validate room access (#24534)

    The request must be blocked If the user has no permission to view rooms.

  • Video and Audio not skipping forward (#19866)

  • VOIP CallContext snapshot infinite loop (#25947)

    The application was crashing due to an error on the useCallerInfo() hook.
    The error was:
    image
    image

    To prevent this issue to happen it was added a cached and out-of-scope snapshot variable to the hook using useSyncExternalStore

  • VoIP disabled/enabled sequence puts voip agent in error state (#25230)

    Initially it was thought that the issue occurs because of the race condition while changing the client settings vs those settings reflected on server side. So a natural solution to solve this is to wait for setting change event 'private-settings-changed'. Then if 'VoIP_Enabled' is updated and it is true, set voipEnabled to true in useVoipClient.ts (on client side)

    It was realised that the race does not happen because of the database or server noticing the changes late. But because of the time taken to establish the AMI connection with Asterisk.

    Solution:

    1. Change apps/meteor/app/voip/server/startup.ts. When VoIP_Enabled is changed, await for Voip.init() to complete and then broadcast connector.statuschanged with changed value.

    2. From apps/meteor/server/modules/listeners/listeners.module.ts use notifyLoggedInThisInstance to notify all logged in users on current instance.

    3. in apps/meteor/client/providers/CallProvider/hooks/useVoipClient.ts add the event handler that receives this event. Change voipEnabled from constant to state. Change this state based on the 'value' that is received by the handler.

  • Voip endpoint permissions (#25783)

  • Wrong argument name preventing Omnichannel Chat Forward to User (#25723)

🔍 Minor changes
  • Bump body-parser from 1.19.2 to 1.20.0 in /ee/server/services (#25042 by @dependabot[bot])

  • Bump ejson from 2.2.1 to 2.2.2 (#25057 by @dependabot[bot])

  • Bump eslint-plugin-anti-trojan-source from 1.0.6 to 1.1.0 (#25076 by @dependabot[bot])

  • Bump minimist from 1.2.5 to 1.2.6 in /ee/server/services (#24991 by @dependabot[bot])

  • Bump pino and pino-pretty (#25052)

  • Bump template-file from 6.0.0 to 6.0.1 (#25002 by @dependabot[bot])

  • Chore: @rocket.chat/favicon (#25920)

  • Chore: refactor/tsc-perf (#26040)

  • Chore: Account/Profile to TS (#25929)

  • Chore: add _id and name options to JSON Schemas (#25813)

    This pull request adds the roomId and roomName options for the Ajv JSON Schemas on the packages/rest-typings/src/v1/channels/ and packages/rest-typings/src/v1/dm/ folders.

  • Chore: Add /v1/video-conference endpoint types (#25278)

  • Chore: Add Agenda fork to the monorepo (#25681)

  • Chore: add Ajv JSON Schema to api/v1 (#25601)

    This pull request adds Ajv JSON Schema validation to apps/meteor/app/api/server/v1/ and packages/rest-typings/src/v1/, where needed.

  • Chore: Add auto label and improve Kodiak configuration (#25829)

  • Chore: Add channel endpoints (rest-typings) (#25279)

  • Chore: Add client folder to CODEOWNERS (#25397)

  • Chore: Add error boundary to message component (#25223)

    Not crash the whole application if something goes wrong in the MessageList component.

    image

  • Chore: Add Livechat repo into Monorepo packages (#25312)

  • Chore: Add missing Swedish livechat translations (#26048 by @joakimaho)

    Added missing Swedish translations.

  • Chore: Add options to debug stdout and rate limiter (#25336)

  • Chore: Add root package.json to houston files (#25286)

    See title

  • Chore: Add tests for agents screens (#25637)

  • Chore: Add typings for /v1/webdav.getMyAccounts (#25276)

  • Chore: Add yarn plugin to check node and yarn version (#25224)

  • Chore: Adding default message parser template (#26064)

  • Chore: adjust in some configurations (#25612)

  • Chore: Allow endpoints to optionally require authentication (#26084)

  • Chore: API test on method GET with params as a number. (#25769)

  • Chore: AutoTranslate contextualBar rewrite (#25751)

  • Chore: Avoid set useless set UTC Offset (#26270)

  • Chore: Avoid unneeded permission updates when EE license is applied (#26253)

  • Chore: Broken Storybook (#25714)

    There is another small improvement on the way we got storybook files.

  • Chore: Bump deps (#25624)

  • Chore: bump fuselage (#25605)

  • Chore: Bump fuselage (#25371)

  • Chore: Bump fuselage and update icon (#26036)

  • Chore: bump fuselage packages (#26325)

  • Chore: Bump Fuselage packages (#25259)

  • Chore: Cancel running jobs if PR is updated (#24708)

  • Chore: Change Apps-Engine version source for info (#26205)

    Now that we're using yarn, the version stored in the package.json is no longer the resolved one, but it matches the input. This means that when we ran yarn add @rocket.chat/apps-engine@alpha, yarn saves "alpha" as the version of the package, while NPM added the resolved version for the tag, e.g. "1.33.0-alpha.6507". This ends up breaking a few places where we need the Apps-Engine version for communication with the Marketplace.

    With this PR we change the source of that info so the problem doesn't happen anymore.

  • Chore: Change stats to daily (#26113)

  • Chore: Check for env var values and not just if they are set (#26219)

  • Chore: Chore add validation option to rest endpoints (#25443)

  • Chore: Close tooltip on click (#26070)

  • Chore: Code Improvements for [FIX] Fixing Network connectivity issues with SIP client. #25391 (#25606)

  • Chore: Collect e2e coverage (#25743)

  • Chore: Colors (#25969)

  • Chore: command's endpoints (#25630)

  • Chore: Convert UserStatusMenu to TS (#25265)

  • Chore: Convert additionalForms (#25586)

  • Chore: Convert Admin -> Rooms to TS (#25348)

  • Chore: Convert admin custom sound to tsx (#25128)

  • Chore: Convert Admin/OAuthApps to TS (#25277)

    • Converts Admin/OAuthApps to TS.

    • migrated forms to react-hook-form

  • Chore: Convert AdminSideBar to ts (#25372)

  • Chore: convert apps/meteor/app/api/server/lib/ files to TS (#25840)

    This pull request converts files on apps/meteor/app/api/server/lib/ to Typescript.

  • Chore: Convert apps/meteor/client/components/UserAutoComplete (#25554)

  • Chore: Convert apps/meteor/client/sidebar/header/index (#25671)

  • Chore: Convert apps/meteor/client/sidebar/search (#25754)

  • Chore: Convert apps/meteor/client/views/admin/settings (#25565)

  • Chore: Convert apps/meteor/client/views/admin/settings/inputs folder (#25427)

  • Chore: Convert assets endpoint to Typescript (#25358)

  • Chore: Convert AutoTranslate (#25591)

  • Chore: Convert client/views/admin/settings/groups folder to ts (#25345)

  • Chore: convert communication methods to Typescript (#25503)

    Convert files from apps/meteor/app/apps/server/communication/ to ts.

  • Chore: Convert components/sidebar to TS (#25429)

  • Chore: Convert Create Channel (#25589)

  • Chore: Convert CreateChannelWithData (#25667)

  • Chore: Convert customSounds folder to ts (#25274)

  • Chore: Convert customUserStatus folder to ts (#25288)

  • Chore: convert e2e to ts (#25958)

    Converted the apps/meteor/app/api/server/v1/e2e.js to ts and created endpoint typings on the packages/rest-typings/src/v1/e2e folder.

  • Chore: Convert email inbox feature to TypeScript (#25298 by @ujorgeleite)

  • Chore: Convert federationDashboard folder to ts (#25343)

  • Chore: Convert getStatistics (#25342)

  • Chore: convert import.js endpoints to TS (#25956)

    Converted the apps/meteor/app/api/server/v1/import.js to ts and created endpoint typings on the packages/rest-typings/src/v1/import folder.

  • Chore: convert info to typescript (#25420)

  • Chore: convert invites, misc and subscriptions to TS and create definitions (#25350)

    Converted apps/meteor/app/api/server/v1/invites.js, misc.js and subscriptions.js to Typescript and created their endpoint definitions on the rest-typings folder.

  • Chore: Convert LivechatAgentActivity to raw model and TS (#25123)

  • Chore: Convert Mailer to TS (#25121)

  • Chore: convert marketplace price display component to use typescript (#25504)

    Marketplace apps listing page
    Screen Shot 2022-05-13 at 12 57 43

    Apps detail page
    Screen Shot 2022-05-13 at 12 58 56

  • Chore: Convert MemoizedSetting, Setting, Section (#25572)

  • Chore: Convert normalizeMessagesForUser (#26059)

  • Chore: Convert NotificationStatus to TS (#25125)

  • Chore: Convert push endpoints to TS (#25347)

  • Chore: Convert RoomForeword, TextCopy and RoomAvatarEditor to TS (#25424)

  • Chore: Convert RoomMenu (#25914)

  • Chore: Convert sidebar/header/actions (#25581)

  • Chore: Convert sidebar/item (#25634)

  • Chore: Convert slashCommands to typescript (#25592 by @eduardofcabrera & @ostjen)

  • Chore: Convert to TS omnichannel/agent (#25511)

  • Chore: Convert to TS RoomAutoComplete (#25536)

  • Chore: Convert to typescript some functions from app/lib/server/functions (#24519)

    Convert to typescript some functions from app/lib/server/functions and transfered theses files to server/lib

  • Chore: Convert to typescript the slash commands help files (#24307 by @eduardofcabrera)

    Convert to typescript the slash commands help files

  • Chore: Convert useFileInput to TS (#25426)

  • Chore: Convert usePreventDefault, useQueryOptions, useShortcutOpenMenu (#26035)

  • Chore: Convert UserAutoCompleteMultiple (#25587)

  • Chore: Convert users endpoints (#25635)

  • Chore: Convert useSidebarPaletteColor (#26065)

  • Chore: Convert useUpdateAvatar to TS and type avatar endpoints (#25430)

  • Chore: Converting files from app/livechat folder from JS to TS (#25658)

    Converting files from apps/meteor/app/livechat/lib/ from JS to TS

  • Chore: Converting omnichannel installation files to ts (#25665)

    This PR converts the omnichannel/installation folder from js to ts

  • Chore: Converting orchestrator.js to ts (#25367)

  • Chore: create a e2e test guideline (#25884)

  • Chore: Create a token for each action (#26023)

  • Chore: Create README.md for Rest Typings (#25335)

  • Chore: Custom Sounds Endpoints (#25633)

  • Chore: Dedicated package for UI contexts (#25432)

    Moving our React contexts to a different package on the monorepo enable us to deliver components from another packages, because they work as a loose connection to the core APIs.

  • Chore: Dependencies upgrade (#25290)

  • Chore: Disabled icon colors on sidebar (#26257)

  • Chore: Do not log integrations using name key (#26163)

  • Chore: Enable marketplace screenshots endpoint (#25395)

  • Chore: ensure scripts use cross-env and ignore some dirs (ROC-54) (#25218)

    • data and test-failure should be ignored

    • ensure scripts use cross-env

  • Chore: Fix CI (#25797)

  • Chore: Fix correct unit test to api files (#25870)

  • Chore: Fix incorrect checksum for agenda package (cause of breaking develop builds) (#25741)

  • Chore: Fix Omnichannel E2E tests not running (#26092)

  • Chore: Fix return type warnings (#25275)

  • Chore: Fix version on develop branch (#25842)

  • Chore: fix watermark condition (#26095)

  • Chore: Fixes e2e playwright intermittences (#25984)

  • Chore: Fuselage update (#26004)

  • Chore: Fuselage update (#25983)

  • Chore: Handle errors on index creation (#26094)

  • Chore: Hide deprecation query log on production (#26188)

  • Chore: Improve CI cache (#25907)

  • Chore: Improve footer Template (#26085)

  • Chore: Increase performance and security of integrations’ scripts (#25641)

    Replace internal VM implementation with VM2 which implements many more mechanisms to ensure timeout, security and allow easier configuration for future improvements on the integrations' feature.

  • Chore: Info page (#26201)

  • Chore: Introduce Modal Region (#25962)

  • Chore: Introduce new index to query active livechat conversations for cloud scaling (#26047)

  • Chore: Keep the option to run only the meteor app (#25915)

  • Chore: Keyboard shortcuts contextualBar rewrite (#25753)

  • Chore: Livechat change output level (#25522)

  • Chore: Major refactors in pageobjects (#26015)

  • Chore: Make kodiak merge message empty (#26069)

  • Chore: Manager Page Rewrite (#25431)

  • Chore: Messages raw model rewrite to ts (#25761)

  • Chore: Migrate 15-message-popup from cypress to playwright (#25462)

  • Chore: migrate from cypress to pw 14-setting-permission (#25523)

  • Chore: migrate katex to ts (#25501)

  • Chore: Migrate LivechatVisitors model to raw (#25756)

  • Chore: Migrate NotFoundPage to TS (#25509)

  • Chore: Migrate oauth2server to typescript (#25126)

  • Chore: Migrate oembed to ts ([Chore: Migrate oembed to ts #25622](https://g

MartinSchoeler and others added 30 commits June 20, 2022 13:17
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
This PR revises the usage of the modal inside the call provider, by moving the modal provider a little bit up the three.
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->
- Fix: add members breaking when searching users

![image](https://user-images.githubusercontent.com/27704687/121788070-b792f700-cba0-11eb-92b9-5833e1213c74.png)

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->


Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
## Proposed changes
- collect e2e coverage
- publish to artifacts
- publish badges to gh-pages
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
The application was crashing due to an error on the `useCallerInfo()` hook.
The error was: 
![image](https://user-images.githubusercontent.com/20212776/174823914-4832e5dd-c91a-4ae4-9d1f-1b960bcd372c.png)
![image](https://user-images.githubusercontent.com/20212776/174823982-cb543fe0-663f-4530-bb94-0720653ca897.png)

To prevent this issue to happen it was added a cached and out-of-scope snapshot variable to the hook using `useSyncExternalStore`

<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce

1. Open rocket.chat server
2. Enable Omnichannel 
3. Enable Voip
4. Refresh de page

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
Co-authored-by: Diego Sampaio <chinello@gmail.com>
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->
Created a new security tab for installed apps that displays information related to the given app security policies, terms of services, and necessary permissions for the use of the app.
Demo gif:
![privacy-tab](https://user-images.githubusercontent.com/43561537/173878394-333057d4-3c7e-434e-a3ca-d3e08f33c7bc.gif)
<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->


Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->
Converted the `apps/meteor/app/api/server/v1/import.js` to ts and created endpoint typings on the `packages/rest-typings/src/v1/import` folder.
<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
Co-authored-by: Pierre <pierre.lehnen@rocket.chat>
Co-authored-by: Douglas Gubert <d-gubert@users.noreply.github.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
I've noted that our extensions api was not using the same pattern that we use for a lot of `GET`s and `DELETE`s.

This will fix an issue when trying to remove an agent from a voip extension.
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
…list (#25475)

<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->

Add a container component to usePosition hook to prevent the menu be rendering outside the container.


Before:
<img width="686" alt="Screen Shot 2022-06-20 at 08 19 08" src="https://user-images.githubusercontent.com/9275105/174591999-15ef8f79-1064-4dd6-b9b1-acf9964b01c2.png">


After:
<img width="657" alt="Screen Shot 2022-06-22 at 10 56 19" src="https://user-images.githubusercontent.com/9275105/175048367-a45443de-9d83-40f8-a4b8-7f2c8be748c2.png">
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
pierre-lehnen-rc and others added 21 commits July 19, 2022 17:49
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Filipe Marins <filipe.marins@rocket.chat>
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
…#26327)

Co-authored-by: Aleksander Nicacio da Silva <aleksander.silva@rocket.chat>
Co-authored-by: Guilherme Gazzo <guilherme@gazzo.xyz>
@murtaza98 murtaza98 requested review from a team as code owners July 21, 2022 18:35
@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2022

This pull request introduces 17 alerts and fixes 9 when merging 1ad49fd into abec1f9 - view on LGTM.com

new alerts:

  • 9 for Information exposure through a stack trace
  • 2 for Variable not declared before use
  • 1 for Useless assignment to local variable
  • 1 for Useless conditional
  • 1 for Missing variable declaration
  • 1 for Unused variable, import, function or class
  • 1 for Missing rate limiting
  • 1 for Use of password hash with insufficient computational effort

fixed alerts:

  • 2 for Useless assignment to local variable
  • 2 for Expression has no effect
  • 1 for Conditional comments
  • 1 for Comparison between inconvertible types
  • 1 for Missing rate limiting
  • 1 for Use of a broken or weak cryptographic algorithm
  • 1 for Template syntax in string literal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet