Chore: Add typings for /v1/webdav.getMyAccounts #25276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
reviewed
Apr 26, 2022
| export type WebdavEndpoints = { | ||
| 'webdav.getMyAccounts': { | ||
| GET: () => { | ||
| accounts: Pick<IWebdavAccount, '_id' | 'username' | 'serverURL' | 'name'>[]; |
There was a problem hiding this comment.
what about create a type to hold this variation? does make any sense sharing this on other place or not?
There was a problem hiding this comment.
idk actually, there is no other place using it.. 🤷♂️
KevLehman
previously approved these changes
Apr 27, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments