Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Ability for RC server to check the business hour for a specific department #25436

Merged
merged 5 commits into from
May 23, 2022

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented May 9, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

  1. Assign the department X to the LiveChat using the widget API code
  2. Enable and setup multiple business hours
  3. Assign the department X to one of the business hours
  4. Enable the Display offline form option

Expected Behavior:
As long as the business hour assigned to department X is closed, the offline form should always be displayed for the visitor.

Actual Behavior:
Sometimes, when the business hour is closed, the LiveChat widget is online instead of offline form. Then, when a visitor initiates a chat, an alert is displayed on the widget saying that there is no agent available for chatting.

Further comments

Related ClickUp task: https://app.clickup.com/t/2fdmbc1

@murtaza98 murtaza98 requested review from a team as code owners May 9, 2022 07:50
@murtaza98 murtaza98 requested a review from a team May 9, 2022 07:51
@murtaza98 murtaza98 added this to the 4.8.0 milestone May 10, 2022
@murtaza98 murtaza98 force-pushed the omni/livechat-bh-setting-on-department branch from a3d5c2f to f54ac17 Compare May 13, 2022 13:00
@murtaza98 murtaza98 force-pushed the omni/livechat-bh-setting-on-department branch from f54ac17 to b2463bc Compare May 19, 2022 18:01
KevLehman
KevLehman previously approved these changes May 19, 2022
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix doesn't look correlated to the problem mentioned by the customer.

packages/livechat/src/lib/main.js Outdated Show resolved Hide resolved
@tiagoevanp tiagoevanp merged commit 54f2ce8 into develop May 23, 2022
@tiagoevanp tiagoevanp deleted the omni/livechat-bh-setting-on-department branch May 23, 2022 18:45
ggazzo pushed a commit that referenced this pull request May 24, 2022
ggazzo pushed a commit that referenced this pull request May 30, 2022
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants