-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Ability for RC server to check the business hour for a specific department #25436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murtaza98
commented
May 10, 2022
KevLehman
reviewed
May 11, 2022
a3d5c2f
to
f54ac17
Compare
murtaza98
commented
May 13, 2022
f54ac17
to
b2463bc
Compare
KevLehman
previously approved these changes
May 19, 2022
tiagoevanp
requested changes
May 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix doesn't look correlated to the problem mentioned by the customer.
…/livechat-bh-setting-on-department
KevLehman
approved these changes
May 23, 2022
tiagoevanp
approved these changes
May 23, 2022
ggazzo
pushed a commit
that referenced
this pull request
May 24, 2022
ggazzo
pushed a commit
that referenced
this pull request
May 30, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Expected Behavior:
As long as the business hour assigned to department X is closed, the offline form should always be displayed for the visitor.
Actual Behavior:
Sometimes, when the business hour is closed, the LiveChat widget is online instead of offline form. Then, when a visitor initiates a chat, an alert is displayed on the widget saying that there is no agent available for chatting.
Further comments
Related ClickUp task: https://app.clickup.com/t/2fdmbc1