Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Sanitize customUserStatus and fix infinite loop #25449

Merged
merged 1 commit into from
May 10, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented May 9, 2022

Proposed changes (including videos or screenshots)

Additional improves:

  • usage of RHF to avoid unnecessary Add and Edit components separately and form validation
  • usage of GenericTableV2 and some hooks to avoid unnecessary code
  • fix IUserStatus type
  • improves in UI design
  • improves empty and loading state
  • improves files structure

[LOOP ERROR ATTACHMENT]
Screen Shot 2022-05-09 at 19 42 53

Issue(s)

Closes #25119

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested review from a team as code owners May 9, 2022 22:33
@dougfabris dougfabris force-pushed the fix/custom-user-status-loop branch from 94b7f0f to 593d255 Compare May 9, 2022 22:44
@dougfabris dougfabris merged commit 7bd248d into develop May 10, 2022
@dougfabris dougfabris deleted the fix/custom-user-status-loop branch May 10, 2022 19:22
@dougfabris dougfabris added this to the 4.8.0 milestone May 10, 2022
gabriellsh added a commit that referenced this pull request May 12, 2022
…lists

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Move admin sidebarItems registration to the main file (#25442)
  [FIX] Sanitize customUserStatus and fix infinite loop (#25449)
  [IMPROVE] Fix multiple bugs with Matrix bridge (#25318)
  Chore: Convert `UserStatusMenu` to TS (#25265)
  Chore: Chore add validation option to rest endpoints (#25443)
  Chore: Add channel endpoints (rest-typings) (#25279)
  Update Codeowners
  Chore: Dedicated package for UI contexts (#25432)
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom User Status Modal Issue
2 participants