[NEW] New button for network outage #25499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: Added a new icon for network disconnection. This icon will show up whenever there is network disconnection.
amolghode1981
commented
May 13, 2022
murtaza98
reviewed
May 13, 2022
murtaza98
reviewed
May 13, 2022
Description: Adding exact versions for fuselage and icons.
MartinSchoeler
requested changes
May 23, 2022
apps/meteor/client/sidebar/sections/components/OmnichannelCallToggleReady.tsx
Outdated
Show resolved
Hide resolved
Description: Taking care of review comments.
MartinSchoeler
previously approved these changes
May 23, 2022
MartinSchoeler
approved these changes
May 23, 2022
ggazzo
pushed a commit
that referenced
this pull request
May 24, 2022
ggazzo
pushed a commit
that referenced
this pull request
May 30, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added a new icon for network disconnection. This icon will show up whenever there is network disconnection.
Proposed changes (including videos or screenshots)
When network outage happens it should be conveyed to the user with special icon. This icon should not be clickable.
Network outage handling is handled in https://app.clickup.com/t/245c0d8 task.
Issue(s)
https://app.clickup.com/t/29wgna9
https://app.clickup.com/t/245c0d8
Steps to test or reproduce
This can be reproduced by turning off the network or stopping asterisk.
Further comments