Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.7.2 #25580

Merged
merged 8 commits into from
May 20, 2022
Merged

Release 4.7.2 #25580

merged 8 commits into from
May 20, 2022

Conversation

d-gubert
Copy link
Member

2022-05-20 · 5 🐛 · 1 🔍 · 6 👩‍💻👨‍💻

Engine versions

  • Node: 14.18.3
  • NPM: 6.14.15
  • MongoDB: 3.6, 4.0, 4.2, 4.4, 5.0

🐛 Bug fixes

  • Dynamic load matrix is enabled and handle failure (#25495)

  • Initial User not added to default channel (#25544)

    If injecting initial user. The user wasn’t added to the default General channel

  • One of the triggers was not working correctly (#25409)

  • UI/UX issues on Live Chat widget (#25407)

  • User abandonment setting is working again (#25520)

    A setting watcher and the query for grabbing abandoned chats were broken, now they're not.

🔍 Minor changes
  • Chore: Add Livechat repo into Monorepo packages (#25312)

👩‍💻👨‍💻 Core Team 🤓

tiagoevanp and others added 7 commits May 20, 2022 12:09
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: Martin <martin.schoeler@rocket.chat>
* [FIX] UI/UX issues on Live Chat widget

* Use @rocketchat/logo

* READ THE ERRORS MARTIN

* Remove old logo

* Fix Reviews

* chore: remove unnecessary class prop

Co-authored-by: dougfabris <devfabris@gmail.com>
* [FIX] One of the triggers was not working correctly

* fix html iteration

* eslint fix

Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
@d-gubert d-gubert requested a review from a team as a code owner May 20, 2022 15:24
@lgtm-com
Copy link

lgtm-com bot commented May 20, 2022

This pull request introduces 1 alert when merging a9fc18a into 21bc94d - view on LGTM.com

new alerts:

  • 1 for Cross-window communication with unrestricted target origin

@@ -0,0 +1,17 @@
module.exports = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda feels like maybe this folder isn't supposed to be checked in? Not sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it was part of moving that to the monorepo.

For the record feels like this shouldn't have been in a patch release. As isn't a fix on its own. It might have included fixes.. but at this point it should have just gone to 4.8.x which hits feature freeze soon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a fix done after moving to monorepo, that's why.. @MartinSchoeler can probably clarify though

@sampaiodiego
Copy link
Member

not sure if something is missing, but CI is failing https://github.com/RocketChat/Rocket.Chat/runs/6527453052?check_suite_focus=true#step:16:398

Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
@lgtm-com
Copy link

lgtm-com bot commented May 20, 2022

This pull request introduces 1 alert when merging df6279a into 21bc94d - view on LGTM.com

new alerts:

  • 1 for Cross-window communication with unrestricted target origin

Copy link
Contributor

@casalsgh casalsgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on all PRs being approved and this is a release PR, approving it

@d-gubert d-gubert merged commit 1688633 into master May 20, 2022
@d-gubert d-gubert deleted the release-4.7.2 branch May 20, 2022 20:08
@ggazzo ggazzo restored the release-4.7.2 branch May 26, 2022 18:20
@d-gubert d-gubert mentioned this pull request May 31, 2022
@sampaiodiego sampaiodiego deleted the release-4.7.2 branch July 21, 2022 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants