[IMPROVE] Refactor + unit tests for federation-v2 #25680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcosSpessatto
changed the title
alansikora
previously approved these changes
May 30, 2022
carlosrodrigues94
previously approved these changes
May 31, 2022
MarcosSpessatto
dismissed stale reviews from carlosrodrigues94 and alansikora
via
e2fc790
carlosrodrigues94
previously approved these changes
Jun 1, 2022
alansikora
previously approved these changes
Jun 2, 2022
MarcosSpessatto
dismissed stale reviews from alansikora and carlosrodrigues94
via
2320a96
ggazzo
previously approved these changes
Jun 6, 2022
alansikora
approved these changes
Jun 6, 2022
ggazzo
approved these changes
Jun 6, 2022
gabriellsh
added a commit
that referenced
this pull request
Jun 6, 2022
…message-body * 'develop' of github.com:RocketChat/Rocket.Chat: [IMPROVE] Refactor + unit tests for federation-v2 (#25680) [FIX] user status Offline misnamed as Invisible in Custom Status edit dropdown menu (#24796) Chore: Messages raw model rewrite to ts (#25761) Chore: migrate katex to ts (#25501) Chore: AutoTranslate contextualBar rewrite (#25751) Chore: Replace AnnouncementModal in favor of GenericModal (#25752) Chore: Keyboard shortcuts contextualBar rewrite (#25753) Chore: Prune Messages contextualBar rewrite (#25757) Chore: add Ajv JSON Schema to api/v1 (#25601) Update package.json (#25755) Update CODEOWNERS Chore: remove duplicated NotFoundPage.js (#25749)
gabriellsh
added a commit
that referenced
this pull request
Jun 6, 2022
* origin/develop: (45 commits) [FIX] Thread Message Preview (#25709) [FIX] Bump meteor-node-stubs to version 1.2.3 (#25669) [IMPROVE] Refactor + unit tests for federation-v2 (#25680) [FIX] user status Offline misnamed as Invisible in Custom Status edit dropdown menu (#24796) Chore: Messages raw model rewrite to ts (#25761) Chore: migrate katex to ts (#25501) Chore: AutoTranslate contextualBar rewrite (#25751) Chore: Replace AnnouncementModal in favor of GenericModal (#25752) Chore: Keyboard shortcuts contextualBar rewrite (#25753) Chore: Prune Messages contextualBar rewrite (#25757) Chore: add Ajv JSON Schema to api/v1 (#25601) Update package.json (#25755) Update CODEOWNERS Chore: remove duplicated NotFoundPage.js (#25749) Chore: command's endpoints (#25630) Chore: Fix incorrect checksum for agenda package (cause of breaking develop builds) (#25741) Chore: Remove duplicate checksumBehavior key from yarn file (#25730) [FIX] Custom emoji reaction size (#25393) Chore: Test for department screen (#25696) Chore: Taking out Blaze from routes with `MainLayout` (#25697) ...
gabriellsh
added a commit
that referenced
this pull request
Jun 6, 2022
* origin/develop: (26 commits) [FIX] Thread Message Preview (#25709) [FIX] Bump meteor-node-stubs to version 1.2.3 (#25669) [IMPROVE] Refactor + unit tests for federation-v2 (#25680) [FIX] user status Offline misnamed as Invisible in Custom Status edit dropdown menu (#24796) Chore: Messages raw model rewrite to ts (#25761) Chore: migrate katex to ts (#25501) Chore: AutoTranslate contextualBar rewrite (#25751) Chore: Replace AnnouncementModal in favor of GenericModal (#25752) Chore: Keyboard shortcuts contextualBar rewrite (#25753) Chore: Prune Messages contextualBar rewrite (#25757) Chore: add Ajv JSON Schema to api/v1 (#25601) Update package.json (#25755) Update CODEOWNERS Chore: remove duplicated NotFoundPage.js (#25749) Chore: command's endpoints (#25630) Chore: Fix incorrect checksum for agenda package (cause of breaking develop builds) (#25741) Chore: Remove duplicate checksumBehavior key from yarn file (#25730) [FIX] Custom emoji reaction size (#25393) Chore: Test for department screen (#25696) Chore: Taking out Blaze from routes with `MainLayout` (#25697) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The main goal for this PR is to add the ability to add tests in our current federation-v2 implementation.
In this PR, I've added only unit tests (80%), but the goal is to add other kinds of tests in the near future.
Also, I've created a diagram to show how this refactor was done, and how is the structure of the code
Issue(s)
Steps to test or reproduce
Further comments