Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] [Device Management] Manage Devices Admin Table #25773

Merged
merged 25 commits into from
Jun 22, 2022

Conversation

yash-rajpal
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@yash-rajpal yash-rajpal requested a review from a team as a code owner June 6, 2022 16:22
@lgtm-com
Copy link

lgtm-com bot commented Jun 6, 2022

This pull request introduces 1 alert when merging 54cfc9c into 7814649 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@dougfabris dougfabris changed the title [NEW][ENTERPRISE] New/mdm admin table [NEW] [Device Management] Manage Devices Admin Table Jun 20, 2022
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job here, congrats!
Some points to take a look at:

  1. There's an overall issue related to TOTP when listing (sessions/list.all) and when getting info about the device (sessions/info.admin) it returning bad requests for some reason even when I set the TOTP auth, I would suggest taking a look on how it behaves without TOTP configured as well.

  2. I'm missing the empty state when there are no devices. Additionally, I would suggest taking a look at the filter, the query is not filtering properly
    Screen Shot 2022-06-20 at 21 49 56

@yash-rajpal yash-rajpal requested a review from a team as a code owner June 22, 2022 14:18
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we could have a unique handleLoggout for the DeviceManagementInfo and for the DeviceManagementRow wdyt?

@RocketChat RocketChat deleted a comment from lgtm-com bot Jun 22, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2022

This pull request introduces 1 alert when merging 4c106c8 into 602d107 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@lgtm-com
Copy link

lgtm-com bot commented Jun 22, 2022

This pull request introduces 1 alert when merging 83d5bc1 into 602d107 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@yash-rajpal yash-rajpal merged commit cfdcecb into new/device-management Jun 22, 2022
@yash-rajpal yash-rajpal deleted the new/mdm-admin-table branch June 22, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants