-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] [Device Management] Manage Devices Admin Table #25773
Conversation
This pull request introduces 1 alert when merging 54cfc9c into 7814649 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job here, congrats!
Some points to take a look at:
-
There's an overall issue related to TOTP when listing (
sessions/list.all
) and when getting info about the device (sessions/info.admin
) it returning bad requests for some reason even when I set the TOTP auth, I would suggest taking a look on how it behaves without TOTP configured as well. -
I'm missing the empty state when there are no devices. Additionally, I would suggest taking a look at the filter, the query is not filtering properly
apps/meteor/ee/client/views/admin/deviceManagement/DevicesTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/views/admin/deviceManagement/DevicesTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/views/admin/deviceManagement/DevicesTable.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/views/admin/deviceManagement/DeviceIcon.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/views/admin/deviceManagement/DeviceInfoContextualBar.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/views/admin/deviceManagement/DeviceInfoContextualBar.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/ee/client/views/admin/deviceManagement/DevicesRow.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we could have a unique handleLoggout
for the DeviceManagementInfo
and for the DeviceManagementRow
wdyt?
apps/meteor/ee/client/views/admin/deviceManagement/DeviceManagementRoute.tsx
Outdated
Show resolved
Hide resolved
This pull request introduces 1 alert when merging 4c106c8 into 602d107 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 83d5bc1 into 602d107 - view on LGTM.com new alerts:
|
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments