Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Room Endpoint Call Issues #25928

Merged
merged 6 commits into from
Jun 27, 2022
Merged

Regression: Room Endpoint Call Issues #25928

merged 6 commits into from
Jun 27, 2022

Conversation

LucianoPierdona
Copy link
Contributor

@LucianoPierdona LucianoPierdona commented Jun 20, 2022

Proposed changes (including videos or screenshots)

This PR fixes small management bugs related with channels, rooms and teams

Issue(s)

Steps to test or reproduce

Further comments

@LucianoPierdona LucianoPierdona self-assigned this Jun 20, 2022
@LucianoPierdona LucianoPierdona changed the title [FIX/room issues [FIX] Room Issues Jun 20, 2022
@LucianoPierdona LucianoPierdona marked this pull request as ready for review June 20, 2022 12:56
@LucianoPierdona LucianoPierdona requested a review from a team as a code owner June 20, 2022 12:56
@dougfabris dougfabris changed the title [FIX] Room Issues [FIX] Room Endpoint Call Issues Jun 20, 2022
yash-rajpal
yash-rajpal previously approved these changes Jun 20, 2022
@ggazzo
Copy link
Member

ggazzo commented Jun 21, 2022

is this not supposed to be a regression?

@matheusbsilva137 matheusbsilva137 changed the title [FIX] Room Endpoint Call Issues Regression: Room Endpoint Call Issues Jun 27, 2022
@ggazzo ggazzo added this to the 5.0.0 milestone Jun 27, 2022
@ggazzo ggazzo merged commit 5109cd3 into develop Jun 27, 2022
@ggazzo ggazzo deleted the fix/room-issues branch June 27, 2022 11:41
gabriellsh added a commit that referenced this pull request Jun 27, 2022
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits)
  Chore: Major refactors in pageobjects (#26015)
  [BREAK] Remove show message in main thread preference (#26002)
  Regression: Webhook Integration Creation + string error toast msg (#26008)
  Chore: convert e2e to ts (#25958)
  Regression: Room Endpoint Call Issues (#25928)
  Chore: Fixes e2e playwright intermittences (#25984)
  Chore: Fuselage update (#26004)
  Chore: Small fix on callProvider (#25963)
  [FIX] Initial members value on Create Channel Modal (#26000)
  Chore: Migrate from meteor model to raw (#25756)
  Chore: VoIP Context (#25994)
  Chore: Fuselage update (#25983)
  [FIX] sidebar colors (#25987)
  Regression: Non-reactive routes (#25990)
  [BREAK] use urlParams on omnichannel/agent/extension/ (#25982)
  [FIX] toolbox menu behind thread component (#25925)
  [FIX] Sort by scope or creation date not working on canned responses list (#25475)
  Chore: Colors (#25969)
  Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980)
  Regression: Prevent Form Submit on Reset Click
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants