Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAK] Remove show message in main thread preference #26002

Merged
merged 3 commits into from
Jun 27, 2022
Merged

[BREAK] Remove show message in main thread preference #26002

merged 3 commits into from
Jun 27, 2022

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 24, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

This PR removes the confusion between the show message in main thread and the function also to send to channel. In the past, we used the show message in main thread as a solution to help users to understand the thread feature, as this feature is now mature enough there's no reason to maintain this preference.

Send the thread message to the main channel or just inside of the thread, should be a decision from the user where the function also send to channel appears. Because of that, and because of a bunch of requests and issues we received, we're introducing a new preference also send thread to channel where users will be able to decide the behavior of the checkbox.

image

Now there are three behavior options

  • Default: when it unchecks after sending the first message

  • Always: stay checked for all messages

  • Never: stay unchecked for all messages

Issue(s)

Closes #20695
Closes #19167
Closes #18347

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested review from a team as code owners June 24, 2022 19:03
This was referenced Jun 24, 2022
Closed
Closed
Closed
@dougfabris dougfabris added this to the 5.0.0 milestone Jun 24, 2022
@github-actions github-actions bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 27, 2022
@kodiakhq kodiakhq bot merged commit e85a63b into develop Jun 27, 2022
@kodiakhq kodiakhq bot deleted the break/showMessageInMainThread branch June 27, 2022 12:57
gabriellsh added a commit that referenced this pull request Jun 27, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into fix/…
4f4a02a 
…turbo

* 'develop' of github.com:RocketChat/Rocket.Chat: (42 commits)
  Chore: Major refactors in pageobjects (#26015)
  [BREAK] Remove show message in main thread preference (#26002)
  Regression: Webhook Integration Creation + string error toast msg (#26008)
  Chore: convert e2e to ts (#25958)
  Regression: Room Endpoint Call Issues (#25928)
  Chore: Fixes e2e playwright intermittences (#25984)
  Chore: Fuselage update (#26004)
  Chore: Small fix on callProvider (#25963)
  [FIX] Initial members value on Create Channel Modal (#26000)
  Chore: Migrate from meteor model to raw (#25756)
  Chore: VoIP Context (#25994)
  Chore: Fuselage update (#25983)
  [FIX] sidebar colors (#25987)
  Regression: Non-reactive routes (#25990)
  [BREAK] use urlParams on omnichannel/agent/extension/ (#25982)
  [FIX] toolbox menu behind thread component (#25925)
  [FIX] Sort by scope or creation date not working on canned responses list (#25475)
  Chore: Colors (#25969)
  Revert "[BREAK] use urlParams on omnichannel/agent/extension/" (#25980)
  Regression: Prevent Form Submit on Reset Click
  ...
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Merged
@reinaldonetof reinaldonetof mentioned this pull request Aug 15, 2022
Merged
10 tasks
@Gummikavalier Gummikavalier mentioned this pull request Aug 22, 2022
Closed
@ankar84 ankar84 mentioned this pull request Aug 23, 2022
Closed
@SaintedSheep SaintedSheep mentioned this pull request Nov 9, 2022
Closed
@aceArt-GmbH
Copy link

there's no reason to maintain this preference

Please revert this change, there is clearly a demand/use-case for the community: #26651 #27220

@TBG-FR
Copy link
Contributor

TBG-FR commented May 3, 2023

You mixed up two different use-cases... While people can understand the behaviour of sending some (first, and maybe important other) thread messages to the main chat, for some communities, some people would like to see all thread messages in main chat, wether or not the box was ticked by the OP when the message was send

Bring back that feature, the two can live together !

@rumato163
Copy link

I think that TBG-FR is absolutely right!
It is a great possibility to watch all the messages in main room if it's needed. But without that option it becomes impossible!

@dougfabris dougfabris mentioned this pull request May 19, 2023
Merged
@dougfabris
Copy link
Member Author

dougfabris commented May 19, 2023 •
edited
Loading

@aceArt-GmbH @TBG-FR @rumato163 After receiving those requests when we did the preference removal, we brought the complaints to the product team and we're planning to bring back the preference on our next release: #29302.
Thanks for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.0
5 participants
@dougfabris @aceArt-GmbH @TBG-FR @rumato163 @ggazzo