-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW][APPS] Allow dispatchment of actions from input elements #25949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2022
Merged
thassiov
changed the title
[NEW][APPS]: allow dispatchment of actions from input elements
[NEW][APPS] allow dispatchment of actions from input elements
Jun 22, 2022
d-gubert
changed the title
[NEW][APPS] allow dispatchment of actions from input elements
[NEW][APPS] Allow dispatchment of actions from input elements
Jun 27, 2022
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Jun 28, 2022
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jun 28, 2022
ggazzo
added
stat: needs QA
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Jun 28, 2022
ggazzo
approved these changes
Jun 30, 2022
ggazzo
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: needs QA
labels
Jun 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This allows for apps receiving block actions when a user types on a plain text input field or selects an item from the static. A debounce of 700 ms is done when listening for typing action so the app is not flooded with actions.
input-element-block-action.mp4
Issue(s)
Steps to test or reproduce
Further comments
Depends on:
Test app used in the video