Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][APPS] Allow dispatchment of actions from input elements #25949

Merged
merged 16 commits into from
Jun 30, 2022

Conversation

thassiov
Copy link
Contributor

@thassiov thassiov commented Jun 21, 2022

Proposed changes (including videos or screenshots)

This allows for apps receiving block actions when a user types on a plain text input field or selects an item from the static. A debounce of 700 ms is done when listening for typing action so the app is not flooded with actions.

input-element-block-action.mp4

Issue(s)

Steps to test or reproduce

Further comments

Depends on:

Test app used in the video

@thassiov thassiov marked this pull request as ready for review June 21, 2022 19:14
@thassiov thassiov requested a review from a team as a code owner June 21, 2022 19:14
@thassiov thassiov changed the title [NEW][APPS]: allow dispatchment of actions from input elements [NEW][APPS] allow dispatchment of actions from input elements Jun 22, 2022
@thassiov thassiov added this to the 5.0.0 milestone Jun 24, 2022
@d-gubert d-gubert changed the title [NEW][APPS] allow dispatchment of actions from input elements [NEW][APPS] Allow dispatchment of actions from input elements Jun 27, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 28, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Jun 28, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Jun 28, 2022
@ggazzo ggazzo added stat: needs QA and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 28, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 30, 2022
@kodiakhq kodiakhq bot merged commit 794a8ea into develop Jun 30, 2022
@kodiakhq kodiakhq bot deleted the new/uikit-element-action branch June 30, 2022 21:34
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: apps stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants