Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAK] Remove support to old MongoDB versions #26098

Merged
merged 9 commits into from
Jul 2, 2022
Merged

[BREAK] Remove support to old MongoDB versions #26098

merged 9 commits into from
Jul 2, 2022

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Jul 1, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

As per MongoDB Lifecycle Schedules (https://www.mongodb.com/support-policy/lifecycles) we're removing official support to MongoDB versions 3.6 and 4.0 that have already reached end-of-life.

As MongoDB 4.2 was a "supported" version before Rocket.Chat 5.0, we'll continue supporting it, but will be flagged as deprecated. We recommend upgrading to MongoDB 4.4+.

Here are official docs on how to upgrade to some of the supported versions:

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner July 1, 2022 19:25
@sampaiodiego sampaiodiego added this to the 5.0.0 milestone Jul 1, 2022
ggazzo
ggazzo previously approved these changes Jul 1, 2022
View reviewed changes
KevLehman
KevLehman previously approved these changes Jul 1, 2022
View reviewed changes
debdutdeb
debdutdeb requested changes Jul 1, 2022
View reviewed changes
Copy link
Member

@debdutdeb debdutdeb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs to be updated

https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/workflows/build_and_test.yml#L756

@KevLehman KevLehman dismissed their stale review July 1, 2022 20:01

checking on one file

@sampaiodiego
Copy link
Member Author

good catch @debdutdeb .. thx 🙏

@debdutdeb
Copy link
Member

I am slightly confused here, are we removing 4.2 or deprecating? The patch shows deprecating but pr description is saying remoing 👀

@KevLehman
Copy link
Contributor

Why this tries to run the tests against 3.6, is a mistery I don't have the answer for
image

@debdutdeb
Copy link
Member

Nvm noticed Kev's edit

@KevLehman
Copy link
Contributor

Nvm noticed Kev's edit

:trollface:

@sampaiodiego
Copy link
Member Author

Why this tries to run the tests against 3.6, is a mistery I don't have the answer for

the pipeline is still mandatory on github branch config.. once this one gets validated I'll go ahead and change github's config to not enforce this pipeline to merge to develop anymore.

debdutdeb
debdutdeb previously approved these changes Jul 1, 2022
View reviewed changes
debdutdeb
debdutdeb previously approved these changes Jul 1, 2022
View reviewed changes
Copy link
Member

@debdutdeb debdutdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this approval from being dismissed plox? 🥲

KevLehman
KevLehman previously approved these changes Jul 1, 2022
View reviewed changes
@KevLehman
Copy link
Contributor

can we keep this approval from being dismissed plox? 🥲

You want me to dismiss it again don't you

@debdutdeb
Copy link
Member

can we keep this approval from being dismissed plox? 🥲

You want me to dismiss it again don't you

You wouldn't 😘

@KevLehman
Copy link
Contributor

can we keep this approval from being dismissed plox? 🥲

You want me to dismiss it again don't you

You wouldn't 😘

Try me :trollface:

@debdutdeb
Copy link
Member

debdutdeb commented Jul 1, 2022 •
edited
Loading

can we keep this approval from being dismissed plox? 🥲

You want me to dismiss it again don't you

You wouldn't 😘

Try me :trollface:

you do that and i'll dm you all the spams every day for a month :trollface:

@RocketChat RocketChat locked as off-topic and limited conversation to collaborators Jul 1, 2022
@KevLehman KevLehman dismissed stale reviews from debdutdeb and themself via 29d3b40 July 1, 2022 22:13
@ggazzo ggazzo added stat: QA skipped stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 2, 2022
@ggazzo ggazzo merged commit 4d99ef0 into develop Jul 2, 2022
@ggazzo ggazzo deleted the remove-mongo-support branch July 2, 2022 01:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@KevLehman KevLehman KevLehman left review comments

@debdutdeb debdutdeb debdutdeb left review comments

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sampaiodiego @debdutdeb @KevLehman @ggazzo @casalsgh