Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Menu options margin spacing #26775

Merged
merged 19 commits into from Sep 6, 2022
Merged

[FIX] Menu options margin spacing #26775

merged 19 commits into from Sep 6, 2022

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Sep 1, 2022

Proposed changes (including videos or screenshots)

  • Change margin spacing from 16-4px to 12-8px
before after
before after

Issue(s)

Steps to test or reproduce

Further comments

Fuselage related PR: RocketChat/fuselage#837

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #26775 (74aeada) into develop (5240f16) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26775      +/-   ##
===========================================
+ Coverage    40.50%   40.54%   +0.04%     
===========================================
  Files          799      799              
  Lines        18296    18296              
  Branches      1954     1954              
===========================================
+ Hits          7410     7419       +9     
+ Misses       10591    10579      -12     
- Partials       295      298       +3     
Flag Coverage Δ
e2e 40.54% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@guijun13 guijun13 marked this pull request as ready for review September 1, 2022 14:34
@guijun13 guijun13 requested a review from a team as a code owner September 1, 2022 14:34
gabriellsh
gabriellsh previously approved these changes Sep 1, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 6, 2022
@kodiakhq kodiakhq bot merged commit 01c8786 into develop Sep 6, 2022
@kodiakhq kodiakhq bot deleted the fix/sidebar-spacing branch September 6, 2022 17:09
@alvaropmello alvaropmello added this to the 5.2.0 milestone Sep 21, 2022
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants