Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Respect convert ascii to emoji preference for new message template #27038

Merged
merged 5 commits into from Oct 14, 2022

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Oct 10, 2022

Proposed changes (including videos or screenshots)

Issue(s)

closes #26681

Steps to test or reproduce

Further comments

@yash-rajpal yash-rajpal requested a review from a team as a code owner October 10, 2022 14:13
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, any chance we add E2E tests for this feature?

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #27038 (1338977) into develop (f4f8cd1) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 1338977 differs from pull request most recent head 2260220. Consider uploading reports for the commit 2260220 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27038      +/-   ##
===========================================
- Coverage    40.33%   40.30%   -0.04%     
===========================================
  Files          827      827              
  Lines        18258    18263       +5     
  Branches      2020     2020              
===========================================
- Hits          7364     7360       -4     
- Misses       10597    10605       +8     
- Partials       297      298       +1     
Flag Coverage Δ
e2e 40.30% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 9d42405 into develop Oct 14, 2022
@kodiakhq kodiakhq bot deleted the convertAcsiiToEmoji-message-rewrite branch October 14, 2022 17:35
@yash-rajpal yash-rajpal added this to the 5.3.0 milestone Oct 17, 2022
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert ASCII to Emoji preference does not appear to be honored.
4 participants