Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Disabling admin actions for federated users #27251

Merged
merged 17 commits into from Feb 13, 2023

Conversation

MarcosSpessatto
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto commented Nov 12, 2022

Proposed changes (including videos or screenshots)

  • Count exclusively federated AND remote users only as federated users. (on Admin)
  • Federated users MUST not be counted as a valid seat cap.
  • Disables the possibility for federated users to add TOTP. (on Admin)
  • Disables the possibility for the admin to activate or inactivate a federated user. (on Admin)
  • Disables the possibility to make a federated user a workspace admin. (on Admin)
  • Disables the possibility to reset E2E key for a federated user. (on Admin)
  • Disables the possibility to change the Role of a federated user (they should always be workspace USERS only) (on Admin)

Jira: FED-51

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/federation-feat-2@6027839). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 8bd2a43 differs from pull request most recent head 3a6a733. Consider uploading reports for the commit 3a6a733 to get more accurate results

Impacted file tree graph

@@                    Coverage Diff                    @@
##             feat/federation-feat-2   #27251   +/-   ##
=========================================================
  Coverage                          ?   42.87%           
=========================================================
  Files                             ?      818           
  Lines                             ?    17289           
  Branches                          ?     1946           
=========================================================
  Hits                              ?     7412           
  Misses                            ?     9611           
  Partials                          ?      266           
Flag Coverage Δ
e2e 42.87% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review November 16, 2022 18:26
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner November 16, 2022 18:26
@MarcosSpessatto MarcosSpessatto modified the milestone: 5.4.0 Nov 16, 2022
@MarcosSpessatto MarcosSpessatto added this to the 6.0.0 milestone Nov 23, 2022
Copy link
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the suggestions and considerations, if you don't agree or have doubts/considerations let's chat

packages/core-typings/src/IUser.ts Outdated Show resolved Hide resolved
@MarcosSpessatto MarcosSpessatto merged commit ca6190f into feat/federation-feat-2 Feb 13, 2023
@MarcosSpessatto MarcosSpessatto deleted the fix/federation-users-admin branch February 13, 2023 13:17
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 13, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: federation stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants