Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove unnecessary permissions check on app permissions review modal #27329

Merged
merged 3 commits into from Jan 9, 2023

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Nov 23, 2022

Proposed changes (including videos or screenshots)

Jira task: MKP-166

Removed an unnecessary check that verified if the app permissions list was an array and threw an error if it wasn't. This check has become unnecessary ever since the app permission review modal changed to show a default list of permissions in case the app happened to not have one and that's what caused those "random" undefined toasts that showed every once in a while.
Demo gif:
undefined_toast

Issue(s)

Steps to test or reproduce

  1. Access the admin section and then the apps option
  2. Install any app that has a 27 item(as of this PR) list of permissions

Further comments

…st bug

Removed an unnecessary check that verified if the app permissions list was an array and threw an error if it wasn't. This check has become unnecessary since I changed the way the app permission review modal worked to show a default list of permissions in case the app happened to not have one.
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #27329 (b4b5d16) into develop (cdc2f99) will increase coverage by 1.30%.
The diff coverage is n/a.

❗ Current head b4b5d16 differs from pull request most recent head 1a1b125. Consider uploading reports for the commit 1a1b125 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27329      +/-   ##
===========================================
+ Coverage    40.94%   42.25%   +1.30%     
===========================================
  Files          838      812      -26     
  Lines        17677    17735      +58     
  Branches      1983     1990       +7     
===========================================
+ Hits          7238     7494     +256     
+ Misses       10201     9953     -248     
- Partials       238      288      +50     
Flag Coverage Δ
e2e 42.25% <ø> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 marked this pull request as ready for review November 25, 2022 14:51
@rique223 rique223 requested a review from a team as a code owner November 25, 2022 14:51
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite the file to TS asserting expected types, maybe this could avoid future errors regarding what is expected from an object property... 🤔

@dougfabris dougfabris dismissed tiagoevanp’s stale review January 9, 2023 13:34

we're going to rewrite the file later

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 9, 2023
@kodiakhq kodiakhq bot merged commit d804469 into develop Jan 9, 2023
@kodiakhq kodiakhq bot deleted the fix/unnecessary-permissions-check-marketplace branch January 9, 2023 14:41
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: apps ecosystem AECO stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants