New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Remove unnecessary permissions check on app permissions review modal #27329
[FIX] Remove unnecessary permissions check on app permissions review modal #27329
Conversation
…st bug Removed an unnecessary check that verified if the app permissions list was an array and threw an error if it wasn't. This check has become unnecessary since I changed the way the app permission review modal worked to show a default list of permissions in case the app happened to not have one.
Codecov Report
@@ Coverage Diff @@
## develop #27329 +/- ##
===========================================
+ Coverage 40.94% 42.25% +1.30%
===========================================
Files 838 812 -26
Lines 17677 17735 +58
Branches 1983 1990 +7
===========================================
+ Hits 7238 7494 +256
+ Misses 10201 9953 -248
- Partials 238 288 +50
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rewrite the file to TS asserting expected types, maybe this could avoid future errors regarding what is expected from an object property... 🤔
we're going to rewrite the file later
Proposed changes (including videos or screenshots)
Jira task: MKP-166
Removed an unnecessary check that verified if the app permissions list was an array and threw an error if it wasn't. This check has become unnecessary ever since the app permission review modal changed to show a default list of permissions in case the app happened to not have one and that's what caused those "random" undefined toasts that showed every once in a while.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments