New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option #27513
[FIX] Save button does not stay disabled in Notification Preferences for no change on mute group option #27513
Conversation
@hugocostadev please review |
I think in this case we're using any falsy value indication. If that's the case not sure whether this patch is necessary or not. |
@debdutdeb is right, I don't think that this is necessary. @xareyli did you face some issues with this? |
I haven't faced any issues with this. Through logging I have figured out that lack of initial value for |
I see. Ok, for now, we don't have a standard for domain specific falsy values (i.e. for strings, '' instead of undefined, for boolean, false instead of undefined, and so on). I think, for now, a better approach to fixing this would be to figure out what frontend logic is handling the state diff first, and see if it can be fixed there. |
I had a little research on this. Here we define the I understand my bad and I am going to create a commit for this PR, which will fix the issue correctly |
@debdutdeb @hugocostadev please review. Think this should work |
Codecov Report
@@ Coverage Diff @@
## develop #27513 +/- ##
===========================================
+ Coverage 41.32% 41.74% +0.42%
===========================================
Files 841 822 -19
Lines 17706 17726 +20
Branches 1996 1994 -2
===========================================
+ Hits 7317 7400 +83
+ Misses 10152 10061 -91
- Partials 237 265 +28
Flags with carried forward coverage won't be shown. Click here to find out more. |
Change the pr title to what you're fixing, not what you're doing code-wise, as that doesn't give us context as to why we need the patch. |
@debdutdeb @hugocostadev if you have spare time, please review |
Proposed changes (including videos or screenshots)
Added default value for "Mute @ALL and @here mentions" option
Issue(s)
Closes #27512
Steps to test or reproduce
Follow the instructions in the issue
Further comments
Lack of default value for
muteGroupMentions
may cause unexpected behavior