Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Threads as React components #27524

Merged
merged 14 commits into from Dec 20, 2022
Merged

Chore: Threads as React components #27524

merged 14 commits into from Dec 20, 2022

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan force-pushed the refactor/threads branch 5 times, most recently from dec1918 to 7dba7b8 Compare December 15, 2022 19:02
@ggazzo ggazzo requested review from a team and removed request for a team December 16, 2022 15:16
@tassoevan tassoevan force-pushed the refactor/threads branch 3 times, most recently from da7835b to 90aef28 Compare December 19, 2022 22:00
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #27524 (4ad302b) into develop (c71714a) will increase coverage by 0.60%.
The diff coverage is 68.59%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27524      +/-   ##
===========================================
+ Coverage    41.13%   41.74%   +0.60%     
===========================================
  Files          845      822      -23     
  Lines        18291    17726     -565     
  Branches      2078     1994      -84     
===========================================
- Hits          7524     7399     -125     
+ Misses       10496    10062     -434     
+ Partials       271      265       -6     
Flag Coverage Δ
e2e 41.74% <68.59%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title Chore: refactor/threads Chore: Threads as React components Dec 20, 2022
@tassoevan tassoevan marked this pull request as ready for review December 20, 2022 17:23
@tassoevan tassoevan requested review from a team as code owners December 20, 2022 17:23
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 20, 2022
@kodiakhq kodiakhq bot merged commit 17db246 into develop Dec 20, 2022
@kodiakhq kodiakhq bot deleted the refactor/threads branch December 20, 2022 19:16
gabriellsh added a commit that referenced this pull request Dec 20, 2022
…/attachment-file

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  Chore: fix EmailInbox intermittent e2e tests (#27573)
  [IMPROVE] Authorize search of custom fields on `users.list` (#27423)
  Chore:  Threads as React components (#27524)
  [NEW] Upload service (#27543)
  [FIX] Fix emoji appearance on sidebar (#27580)
  [FIX] RoomLeader status not working (#27576)
  [FIX] Announcement banner link opening in the same page (#27554)
  Bump version to 5.4.1
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Fix Login with Show default form disabled (#27475)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  [FIX] Pagination not working on current chats (#27432)
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  Regression: Add button-icon-disabled-color to the palette (#27522)
  Chore: Refactor CreateChannelModal (#27469)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants