Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Custom languages not being applied to i18next #27557

Merged
merged 3 commits into from Dec 16, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Dec 15, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added this to the 5.4.1 milestone Dec 15, 2022
@ggazzo ggazzo requested a review from a team as a code owner December 15, 2022 18:13
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #27557 (cbe7a2b) into develop (f53520f) will increase coverage by 0.89%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27557      +/-   ##
===========================================
+ Coverage    41.20%   42.09%   +0.89%     
===========================================
  Files          845      818      -27     
  Lines        18291    17772     -519     
  Branches      2078     2003      -75     
===========================================
- Hits          7537     7482      -55     
+ Misses       10479    10019     -460     
+ Partials       275      271       -4     
Flag Coverage Δ
e2e 42.09% <ø> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggazzo ggazzo merged commit 99d1440 into develop Dec 16, 2022
@ggazzo ggazzo deleted the fix/custom-translation branch December 16, 2022 11:40
@ggazzo ggazzo mentioned this pull request Dec 16, 2022
gabriellsh added a commit that referenced this pull request Dec 20, 2022
…/attachment-file

* 'develop' of github.com:RocketChat/Rocket.Chat: (33 commits)
  Chore: fix EmailInbox intermittent e2e tests (#27573)
  [IMPROVE] Authorize search of custom fields on `users.list` (#27423)
  Chore:  Threads as React components (#27524)
  [NEW] Upload service (#27543)
  [FIX] Fix emoji appearance on sidebar (#27580)
  [FIX] RoomLeader status not working (#27576)
  [FIX] Announcement banner link opening in the same page (#27554)
  Bump version to 5.4.1
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Fix Login with Show default form disabled (#27475)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  [FIX] Pagination not working on current chats (#27432)
  [FIX] Custom languages not being applied to i18next (#27557)
  [FIX] Registration and Login placeholders not being used (#27558)
  [FIX] Message Actions menu does not close upon choosing an action (#27328)
  Chore: Deprecate unused omnichannel API (#27538)
  Regression: Add button-icon-disabled-color to the palette (#27522)
  Chore: Refactor CreateChannelModal (#27469)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants