Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAK] Update Meteor to 2.9.1 and NodeJS to 14.21.2 #27639

Merged
merged 24 commits into from Jan 9, 2023

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Dec 26, 2022

ARCH-85

Proposed changes (including videos or screenshots)

This is a two version bump. Change log details can be found at https://docs.meteor.com/changelog.html#v2920221212

Issue(s)

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #27639 (711f629) into develop (cdc2f99) will increase coverage by 1.10%.
The diff coverage is 65.38%.

❗ Current head 711f629 differs from pull request most recent head 56ef256. Consider uploading reports for the commit 56ef256 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27639      +/-   ##
===========================================
+ Coverage    40.94%   42.05%   +1.10%     
===========================================
  Files          838      810      -28     
  Lines        17677    17130     -547     
  Branches      1983     1909      -74     
===========================================
- Hits          7238     7204      -34     
+ Misses       10201     9685     -516     
- Partials       238      241       +3     
Flag Coverage Δ
e2e 42.05% <65.38%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego marked this pull request as ready for review January 3, 2023 03:23
@sampaiodiego sampaiodiego requested review from a team as code owners January 3, 2023 03:23
tassoevan
tassoevan previously approved these changes Jan 4, 2023
ggazzo
ggazzo previously approved these changes Jan 5, 2023
ggazzo
ggazzo previously approved these changes Jan 5, 2023
MartinSchoeler
MartinSchoeler previously approved these changes Jan 5, 2023
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working normally with the omnichannel part of this PR

tassoevan
tassoevan previously approved these changes Jan 6, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 6, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jan 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 9, 2023
@sampaiodiego sampaiodiego merged commit b0a848a into develop Jan 9, 2023
@sampaiodiego sampaiodiego deleted the meteor-update-2.9 branch January 9, 2023 18:56
@sampaiodiego sampaiodiego changed the title [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.2 Jan 9, 2023
@sampaiodiego sampaiodiego changed the title [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.2 [BREAK] Update Meteor to 2.9.1 and NodeJS to 14.21.2 Jan 9, 2023
gabriellsh added a commit that referenced this pull request Jan 11, 2023
…customRolesUpsell

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Composer Toolbox overlapping borders (#27714)
  [FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component (#27533)
  [FIX] Discussion visibility when inside a private team. (#27601)
  Chore: Restrict legacy message events (#27691)
  [FIX] Anonymous user buttons (#27551)
  [BREAK] [FIX] VideoConference Ringer working intermittently on microservices (#27703)
  [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639)
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants