[FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component #27533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27533 +/- ##
===========================================
+ Coverage 41.44% 42.33% +0.88%
===========================================
Files 840 814 -26
Lines 17699 17184 -515
Branches 1995 1921 -74
===========================================
- Hits 7335 7274 -61
+ Misses 10125 9673 -452
+ Partials 239 237 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
previously approved these changes
Jan 8, 2023
dionisio-bot
bot
added
stat: ready to merge
tiagoevanp
force-pushed
the
fix/apps-contextual-bar-close-danger
branch
from
71a267c
to
7e4ccf3
Compare
tiagoevanp
force-pushed
the
fix/apps-contextual-bar-close-danger
branch
from
7e4ccf3
to
b1eb54f
Compare
tassoevan
approved these changes
Jan 9, 2023
gabriellsh
added a commit
that referenced
this pull request
Jan 11, 2023
…customRolesUpsell * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Composer Toolbox overlapping borders (#27714) [FIX] Add the possibility of danger style prop to close button on UiKit contextual-bar component (#27533) [FIX] Discussion visibility when inside a private team. (#27601) Chore: Restrict legacy message events (#27691) [FIX] Anonymous user buttons (#27551) [BREAK] [FIX] VideoConference Ringer working intermittently on microservices (#27703) [BREAK] Update Meteor to 2.9 and NodeJS to 14.21.1 (#27639)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments