Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Omnichannel analytics conversion to typescript #27940

Merged
merged 13 commits into from Mar 15, 2023

Conversation

FabioCavaleti
Copy link
Contributor

@FabioCavaleti FabioCavaleti commented Feb 2, 2023

Proposed changes (including videos or screenshots)

In this PR I converted the omnichannel analytics files to typescript

Issue(s)

Steps to test or reproduce

Further comments

OC-631

@FabioCavaleti FabioCavaleti changed the title Conversion completed Chore: Omnichannel analytics conversion to typescript Feb 2, 2023
@FabioCavaleti FabioCavaleti self-assigned this Feb 2, 2023
@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #27940 (e8e42ea) into develop (1bc2402) will increase coverage by 5.89%.
The diff coverage is n/a.

❗ Current head e8e42ea differs from pull request most recent head 4b416b2. Consider uploading reports for the commit 4b416b2 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27940      +/-   ##
===========================================
+ Coverage    39.22%   45.11%   +5.89%     
===========================================
  Files          691      759      +68     
  Lines        13628    14688    +1060     
  Branches      1999     2075      +76     
===========================================
+ Hits          5345     6627    +1282     
+ Misses        8032     7767     -265     
- Partials       251      294      +43     
Flag Coverage Δ
e2e 45.07% <ø> (+5.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@FabioCavaleti FabioCavaleti marked this pull request as ready for review February 6, 2023 16:41
@FabioCavaleti FabioCavaleti requested a review from a team as a code owner February 6, 2023 16:41
KevLehman
KevLehman previously approved these changes Feb 27, 2023
filipemarins
filipemarins previously approved these changes Mar 6, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2023
@dougfabris dougfabris changed the title Chore: Omnichannel analytics conversion to typescript refactor: Omnichannel analytics conversion to typescript Mar 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 14, 2023
@MartinSchoeler MartinSchoeler added this to the 6.1.0 milestone Mar 14, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 15, 2023
@MartinSchoeler MartinSchoeler added the stat: ready to merge PR tested and approved waiting for merge label Mar 15, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 15, 2023
@kodiakhq kodiakhq bot merged commit 0c6e979 into develop Mar 15, 2023
35 checks passed
@kodiakhq kodiakhq bot deleted the chore/analytics-conversion-to-ts branch March 15, 2023 17:06
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants